What about PEP8 (http://www.python.org/dev/peps/pep-0008/)? There are a lot of style issues all over the sources. I would be willing to cleanup the sources.
Christian.
What about PEP8 (http://www.python.org/dev/peps/pep-0008/)? There are a lot of style issues all over the sources. I would be willing to cleanup the sources.
Christian.
I had a very short conversation with Michael about this a few days ago. PEP8 was specifically not made a requirement to reduce the barrier for contribution.
I am a big fan of pep8, and generally adhere to it strictly, and have done so with the code I have contributed.
However, I am hugely against updating code for the sole purpose of style changes. Updating code in this way, is terrible for things like blame.
In addition to that, a large percentage of the ~90 open pull requests would be broken and require refactoring, as they would no longer cleanly merge.
Almost every project I have ever worked with, discourages these types of code updates for specifically these reasons. If you are updating a small portion of code, that could benefit from style changes, do it then. Little by little the code style gets updated.
We have a “make pep8” target in the Makefile that we periodically use that ignores issues we do not care about but correct hundreds of others.
Generally pep8 is too strict in a few areas.
Please complain to me directly as opposed to this list if you disagree.
– Michael
I usually PEP8 and apply style change only to the files I’m working on. So usually just one file. Is that permissible?
Justin