New NetworkManager module PR#482: What are the next steps to getting it merged?

Hi All.

I’ve submitted my first PR for a new module and it has been tagged with ‘feature_pull_request’ ‘new_module’ ‘P3’ and has a green tick. What’s the next step in the process for that PR to get merged?

Cheers
Chris Long

Looks like bcoca is already reviewing it and providing some feedback.
Next step is to fix the issues he's pointing out. :slight_smile:

--g

Thanks for the response Greg.

You're correct, bcoca has reviewed it and I've fixed the issues as per his suggestions now. PR has been repushed.

Thanks too, bcoca.

Cheers

Chris Long
Snr Systems Engineer,
PnT Developer Operations SysOps Team
Red Hat, Australia
Ph: +61735147148
Mobile: +61402919942

"Do what you love doing, with people who you like being with, to the overall benefit of society - build individual and collective wealth in the team."

Can this be merged now please? I have completed the corrections :slight_smile:

Cheers

Chris Long