Trailing white space policy

Hello All,

Would it be a good idea to have a policy that files cannot have trailing white space? The problem is that some editors are set up to remove this automatically, and when changing a file introduce a patch with trailing white space removed.

If files do not have trailing white space (and there is no good reason to have them, then simply using an editor that doesn’t remove them automatically), then this would never be a problem.

That would make contributing to ansible easier: you will never have to tell a person to keep white space. Trailing white space can also be removed automatically upon commit perhaps, so it can never be introduced inadvertedly, or else such a commit can be rejected.

What does ansible think?

All the best,

Berend.

Ansible doesn’t care about trailing whitespace, and enjoys annoying those that have a problem with it.

We do not accept patches to fix because that breaks line attribution.

turn it off on your editor, but if you contribute any changes remove the trailing whitespace from those lines, eventually most of it will be removed.

if you contribute any changes remove the trailing whitespace from those lines, eventually most of it will be removed.

If there is no policy from now on not to accept trailing white spaces, it will continually be introduced again.

I think you miss the point where we don’t care about removing trailing whitespace.

So many millions of things that are a better use of our time, in the face of some absolutely awesome contributions and things to work on.

I got that loud and clear, and respect that. I simply responded to Brian who thought the trailing white space would disappear with edits over time.

All the best,

Berend.

Just cause they bug me and find excuses to send PRs for code all over ansible :rage:

Brian Coca

You have discovered my evil scheme to convince you to patch all the things!

I KNEW IT!​