Hi,
I have developed a Windows version of the wait_for module that mimics part of functionality of the Linux wait_for module.
Currently my module is capable of the following:
wait for the existence of a file (path parameter) when state=present
wait for a file (set by path parameter) to not exist when state=absent
wait for a file (set by path parameter) to contain a string matching a regular expression (set by search_regex parameter)
I would like to share this with the community to enable others to add more functionality and to reuse what i have done so far.
Should I create a pull request to contribute this?
Also, if i have multiple modules to share, should this be done in one pull request or multiple? Sorry for the dumb question but i am new to this
Thanks
Hi,
Definitely create a pull request, its the best way to get your code reviewed by others (and the only way to get it included with ansible). Definitely worth working your way through this if you haven’t read it yet - http://docs.ansible.com/ansible/developing_modules.html
Also, please create one pull request per module.
Many thanks.
Jon
Matt_Davis
October 20, 2016, 11:50pm
3
Yeah, I had that one on my list as a planned core module build for 2.3, so if you’ve got a decent start on one, let’s see it!
-Matt
As I work for a software vendor, I have to wait for approval before I do the pull request.
I have started that process, and as soon as I have it, I will share my work.
I have included the generated doc page to whet the appetite and explain where i have got to.
(attachments)
win_wait_for.md (2.73 KB)
I have approval from my company and will create the pull request today.
