Vagrant Ansible Provisioner - best practice

Ive been asked to use Ansible to create a CI and CD pipeline - i have extensive knowledge of Puppet and know experience of Ansible - im almost two weeks in and after trying to model Ansible with same concepts derived from Puppet im almost happy

Some frustrations aside i wondered whether I am doing things a ok

My setup is thus -

I have a Packer repo to build OS
I have an Ansible repo using ansible-galaxy (like i did with r10k)
Vagrant repo and ansible is including in the project as a submodule

I have a nodes.yaml file like so: