Hey all, I’ve made a small fix to correct an issue I was having with templates extending from other templates. PR: https://github.com/ansible/ansible/pull/8127
This is a pretty simple change, but I wonder if anyone was relying on the previous behavior? My fix makes templates refer to each other using paths relative to the template doing the extending; this follows the same pattern used by playbooks that include each other. The prior behavior, which I think should probably be considered a bug, was for all paths to be relative to the root template.
Review usually happens on the actual PR, though it’s fine to start a thread here.
Minor, but I’d like to see the tests grouped in with the other template tests, since this does not seem to be a large portion of thigns.
I’m not sure how many people use extend (I’d guess almost none) so I suspect this might not hurt anyone, but would it hurt anyone anyway? Absolutes seem like they would still work too, and otherwise it would have been relative to just CWD, which seems weird, and deserving of breakage if we can make it more logical.
Sound about right?