First code contribution to Ansible, looking for feedback

Archives Ansible Developer
1

Hi,

I’m just starting to write some code for a first code PR to Ansible. It’s still a work in progress, but I just want to get some feedback and see if I’m working in the right direction.

It’s in response to this issue:

https://github.com/ansible/ansible-modules-core/issues/4386

My initial exploratory commit is here:

https://github.com/bordeltabernacle/ansible/commit/34b180cf7f3b5735111d89047ad1f6d7bd169253

I’ll look at adding some more checks on the path arg, maybe a try/except. I’m not sure though if there’s anything else to consider, especially outside the method. I assume the functionality in the network modules to use this will be added in another PR, but is there something I’m overlooking or missing?

Any advice/comment, good or bad, will be most welcome.

Thanks,

Rob

2

Left one comment on that commit, though Peter or one of the other network team will be the ones merging it.

In general, just go ahead and submit your PR to get it reviewed with feedback, unless it’s about adding a large new feature (in which case having some discussion here on the devel mailing list first may save you some headaches).

Thanks!