Hey everyone! I am working on my first contribution and, after banging my head and asking around, I am out of ideas. I have a PR open (Add Performance Insights and Database Insights to rds_cluster.py by randoneering · Pull Request #2543 · ansible-collections/amazon.aws · GitHub) and I still need to add some integration testing for the new parameters I am trying to add (enabling performance insights at the cluster level and database insights at cluster level). I am hitting to road blocks and I am hoping someone could be another set of eyes to help me along.
- I am hitting an error with the documentation check. I have gone through and manually deleted rows to make sure I didn’t somehow carry over hidden unicode characters, but I continue to get errors each time I fix whatever the new offending lines pop on on the error. I have done this twice and want to make sure there isn’t a better way to find this wonderful hidden gems…
Invoke build script '/home/runner/work/_temp/docsbuild/head/build.sh'
~/work/_temp/docsbuild/head ~/work/amazon.aws/amazon.aws
Found errors in some modules or plugins:
amazon.aws.rds_cluster module: Missing documentation or could not parse documentation: amazon.aws.rds_cluster did not contain a DOCUMENTATION attribute (/home/runner/work/amazon.aws/amazon.aws/ansible_collections/amazon/aws/plugins/modules/rds_cluster.py). Unable to parse documentation in python file '/home/runner/work/amazon.aws/amazon.aws/ansible_collections/amazon/aws/plugins/modules/rds_cluster.py': while scanning a simple key
in "<unicode string>", line 86, column 11
could not find expected ':'
in "<unicode string>", line 87, column 11. while scanning a simple key
in "<unicode string>", line 86, column 11
could not find expected ':'
in "<unicode string>", line 87, column 11
~/work/amazon.aws/amazon.aws
- The second is an error I deal with from time to time when writing playbooks for work and a variable that I am passing through is empty. However, I have read through the code I added and I am not sure what I could be possibly missing?
File "/var/folders/xf/9g1j8gwx46g13dyjw6_fnj8c0000gp/T/ansible_amazon.aws.rds_cluster_payload_v_sx5ebx/ansible_amazon.aws.rds_cluster_payload.zip/ansible_collections/amazon/aws/plugins/modules/rds_cluster.py", line 1136, in changing_cluster_options
KeyError: 'EnablePerformanceInsights'
fatal: [localhost]: FAILED! => {
"changed": false,
"module_stderr": "Traceback (most recent call last):\n File \"/Users/jfrye/.ansible/tmp/ansible-tmp-1741219030.4587781-50196-31706941389543/AnsiballZ_rds_cluster.py\", line 107, in <module>\n _ansiballz_main()\n ~~~~~~~~~~~~~~~^^\n File \"/Users/jfrye/.ansible/tmp/ansible-tmp-1741219030.4587781-50196-31706941389543/AnsiballZ_rds_cluster.py\", line 99, in _ansiballz_main\n invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)\n ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File \"/Users/jfrye/.ansible/tmp/ansible-tmp-1741219030.4587781-50196-31706941389543/AnsiballZ_rds_cluster.py\", line 47, in invoke_module\n runpy.run_module(mod_name='ansible_collections.amazon.aws.plugins.modules.rds_cluster', init_globals=dict(_module_fqn='ansible_collections.amazon.aws.plugins.modules.rds_cluster', _modlib_path=modlib_path),\n ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n run_name='__main__', alter_sys=True)\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File \"<frozen runpy>\", line 226, in run_module\n File \"<frozen runpy>\", line 98, in _run_module_code\n File \"<frozen runpy>\", line 88, in _run_code\n File \"/var/folders/xf/9g1j8gwx46g13dyjw6_fnj8c0000gp/T/ansible_amazon.aws.rds_cluster_payload_v_sx5ebx/ansible_amazon.aws.rds_cluster_payload.zip/ansible_collections/amazon/aws/plugins/modules/rds_cluster.py\", line 1495, in <module>\n File \"/var/folders/xf/9g1j8gwx46g13dyjw6_fnj8c0000gp/T/ansible_amazon.aws.rds_cluster_payload_v_sx5ebx/ansible_amazon.aws.rds_cluster_payload.zip/ansible_collections/amazon/aws/plugins/modules/rds_cluster.py\", line 1473, in main\n File \"/var/folders/xf/9g1j8gwx46g13dyjw6_fnj8c0000gp/T/ansible_amazon.aws.rds_cluster_payload_v_sx5ebx/ansible_amazon.aws.rds_cluster_payload.zip/ansible_collections/amazon/aws/plugins/modules/rds_cluster.py\", line 1235, in ensure_present\n File \"/var/folders/xf/9g1j8gwx46g13dyjw6_fnj8c0000gp/T/ansible_amazon.aws.rds_cluster_payload_v_sx5ebx/ansible_amazon.aws.rds_cluster_payload.zip/ansible_collections/amazon/aws/plugins/modules/rds_cluster.py\", line 1136, in changing_cluster_options\nKeyError: 'EnablePerformanceInsights'\n",
"module_stdout": "",
"msg": "MODULE FAILURE: No start of json char found\nSee stdout/stderr for the exact error",
"rc": 1
}
Thank you @alinabuzachis for helping me get this far (and gently reminding me there are documents/guides on contributions ).
I am happy to chat through this forums and provide ANY information I can.
)
