How to disable `gather_facts` and cowsays in `ansible-test integration`

sumanth-lingappa · January 2, 2024, 7:56am

I am unable to disable gathering_facts and cowsay even when they are disabled in my environent variable and ~/.ansible.cfg file

❯ cat ~/.ansible.cfg
[defaults]
gathering = explicit
nocows = 1


❯ echo $ANSIBLE_NOCOWS
1

❯ echo $ANSIBLE_GATHERING
explicit

❯ ansible-test integration 
Running nsip integration test role
 _________________ 
< PLAY [testhost] >
 ----------------- 
        \   ^__^
         \  (oo)\_______
            (__)\       )\/\
                ||----w |
                ||     ||

 ________________________ 
< TASK [Gathering Facts] >
 ------------------------ 
        \   ^__^
         \  (oo)\_______
            (__)\       )\/\
                ||----w |
                ||     ||

ok: [testhost]
 __________________________________ 
< TASK [nsip : Add NSIP | --check] >
 ---------------------------------- 
        \   ^__^
         \  (oo)\_______
            (__)\       )\/\
                ||----w |
                ||     ||

changed: [testhost -> localhost]
 _______________________________________ 
< TASK [nsip : Assert on add | --check] >
 --------------------------------------- 
        \   ^__^
         \  (oo)\_______
            (__)\       )\/\
                ||----w |
                ||     ||

ok: [testhost] => {
    "changed": false,
    "msg": "All assertions passed"
}

 ____________ 
< PLAY RECAP >
 ------------ 
        \   ^__^
         \  (oo)\_______
            (__)\       )\/\
                ||----w |
                ||     ||

testhost                   : ok=2   changed=1    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

felixfontein · January 2, 2024, 8:11am

I’ve never seen cowsay being used in ansible-test integration. Can you provide more information on your environment, or preferably a way to reproduce it? (Maybe starting with an empty container so it’s easy to fully reproduce the environment.)

sumanth-lingappa · January 2, 2024, 8:33am

You are right @felixfontein.

I tried in an empty container and I didn’t get the cowsay

Do you guess any problem in my environment?

root@008c7af128a2:/ansible_collections/netscaler/adc# ansible-test integration
WARNING: Using locale "C.UTF-8" instead of "en_US.UTF-8". Tests which depend on the locale may behave unexpectedly.
Running nsip integration test role

PLAY [testhost] ****************************************************************

TASK [Gathering Facts] *********************************************************
ok: [testhost]

PLAY RECAP *********************************************************************
testhost                   : ok=1    changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

felixfontein · January 2, 2024, 10:50am

I guess there is, but I don’t know what could trigger this. Maybe @mattclay has an idea?

chris · January 2, 2024, 11:41am

Uninstall cowsay? If you are running a Debian based distro:

apt purge cowsay

sumanth-lingappa · January 2, 2024, 11:49am

I don’t want to uninstall cowsay @chris

mattclay · January 2, 2024, 10:15pm

Fact gathering can be disabled in individual integration tests by adding gather_facts/no to the aliases file for that test.

Currently the only way to prevent cowsay from being used is to ensure it’s not present on the system running the tests. The --docker option is one way to accomplish that.

sumanth-lingappa · January 3, 2024, 5:24am

Thank you @mattclay, your suggestion to include gather_facts/no helped me to stop gathering facts.

However, I looked into the ansible/ansible code.

In the below line, it is checking for gather_facts/no/ (the last slash) in the target.aliases.

How does gather_facts/no (without the last slash) work?

Am I missing something?

github.com

ansible/ansible/blob/55065c00428cf857d501b7183ed8be34841f8025/test/lib/ansible_test/_internal/commands/integration/init.py#L668


      
              )
          elif isinstance(args, NetworkIntegrationConfig):
              hosts = target.network_platform
              gather_facts = False
          else:
              hosts = 'testhost'
              gather_facts = True
          
          if 'gather_facts/yes/' in target.aliases:
              gather_facts = True
          elif 'gather_facts/no/' in target.aliases:
              gather_facts = False
          
          if not isinstance(args, NetworkIntegrationConfig):
              cloud_environment = get_cloud_environment(args, target)
          
              if cloud_environment:
                  env_config = cloud_environment.get_environment_config()
          
          if env_config:
              display.info('>>> Environment Config\n%s' % json.dumps(dict(

mattclay · January 3, 2024, 5:42am

Internally, ansible-test adds a trailing / to most aliases during parsing, so gather_facts/no becomes gather_facts/no/ by the time it’s saved in target.aliases.

sumanth-lingappa · January 3, 2024, 5:44am

Thank you @mattclay

Can I please ask you the code in the ansible repo? (I hope I am not asking too much )

mattclay · January 3, 2024, 4:41pm

The / is added here:

github.com

ansible/ansible/blob/ef1e01aa8b919ef8a9478c5c488bcd3a708ff517/test/lib/ansible_test/_internal/target.py#L676


      
          if target_type != actual_type:
              # allow users to query for the actual type
              groups.extend(['context/', f'context/{actual_type.name.lower()}'])
          
          self.target_type = target_type
          self.actual_type = actual_type
          
          # aliases
          
          aliases = [self.name] + \
                    ['%s/' % g for g in groups] + \
                    ['%s/%s' % (g, self.name) for g in groups if g not in self.categories]
          
          if 'hidden/' in aliases:
              aliases = ['hidden/'] + ['hidden/%s' % a for a in aliases if not a.startswith('hidden/')]
          
          self.aliases = tuple(sorted(set(aliases)))
          
          # configuration
          
          self.retry_never = 'retry/never/' in self.aliases

system · February 2, 2024, 4:41pm

This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.