AWS MediaLive module PR: Guidance needed on CI build failures

Hi AWS Ansible community,

I’ve submitted a PR to the community.aws repository that adds new MediaLive modules. While the code and tests work in my environment, I’m encountering two build failures that I need help addressing:

  1. Documentation Build Failure
  • I’ve noticed this same documentation build error appearing in other recently merged PRs
  • Would appreciate guidance on whether this is a known issue that can be bypassed
  1. Integration Test Permissions
  • The integration tests run successfully in my environment using an IAM role with MediaLive permissions
  • The automated build system appears to be failing due to insufficient IAM permissions for MediaLive and IAM
  • Looking for confirmation if this is an environment-specific issue that needs to be addressed at the CI level

PR Link: feat(medialive): add Elemental MediaLive modules to community collection by buxell · Pull Request #2318 · ansible-collections/community.aws · GitHub

I’ve commented on the PR but haven’t received any response. Would greatly appreciate any guidance on how to proceed with these build failures or if they can be considered non-blocking for this contribution.

Thanks in advance for any help!

2 Likes

@buxell Welcome to the forum, thanks for your PR and pointing out this problems

@bianca I know you often help with community.aws.

It looks like module documentation builds have been failing in community.aws for a while. Is this a know issue?

Any ideas on the other questions that @buxell has?

Hi @buxell ! The module documentation build failures are a known issue, and are not typically considered a PR blocker.

Thanks for linking to your PR; I went ahead and approved the workflow run, so the full test suite should be running now.

@bianca Thanks, I think we’ve fixed the underlying documentation issues in this pr.

Do you know how we update the IAM permissions

Integration test failures in CI - I’ve confirmed these tests pass locally using an IAM role with the required MediaLive permissions. Looking for guidance on how to update the CI environment’s IAM role to include these permissions, if that is needed.

I unfortunately don’t have the answer, but I’ve reached out to teammates who might know how to resolve this issue.

1 Like

There is some information about updating CI permissions in Guidelines for Ansible Amazon AWS module development — Ansible Community Documentation.

2 Likes

Thanks everyone for the prompt feedback! I’ve rebased the PR, and while the doc build is still failing, I’ve identified a few formatting issues in our docstrings that I can resolve. For the integration tests, I’ll be working on gathering the minimum required IAM permissions to submit a PR to mattclay/aws-terminator. I’ll update once these changes are complete.

2 Likes

I’ve created a PR in the aws-terminator repository to add the required MediaLive IAM permissions that should resolve the integration test failures in CI.

I’ve also updated the docstrings in the original MediaLive modules PR and resolved the documentation formatting issues - the Doc Build is now passing successfully. Once the aws-terminator PR is merged, the integration tests should pass as well.