zabbix_maintenance minor improvements

Archives Ansible Developer
1

Hi

I just made a PR https://github.com/ansible/ansible/pull/8841 for a minor improvment in this new module. Since this module is in devel only, I wanted to ask if those changes could make it in final 1.8.

I made 2 rather smal commitsl, which help me with the daily work with this module. The first commit defaults the state option to present which is the default for many (all?) modules I saw having this argument.

The second change helps me saving time by providing the login data once in environment variables, but you can also still provide them with args like before the change, or mix them. Regarding in the future, I also wanted to have more zabbix modules, e.g. zabbix_host for adding new hosts, which can make use of those variables too.

Thanks for your time and work.

Regads
René

2

Just wanted to let you know I rebased the PR to make the change looks more logical and understandable. These commits does not change the existing functionality, even though the module is new in 1.8.

Would be glad if it could make it into 1.8.

3

Hi

4

Hi Rene,

Thanks for the contribution.

You’re in queue, but we are currently tackling P1 and P2 items before moving to P3s and so on.

I can’t make any promises on 1.8, but please stay tuned.

Thanks!