Unexpected exception when including tasks from main.yml

Archives Ansible Project
1

Ansible assumes that roles/x/tasks/main.yml is a plain list of tasks, but when the file is in the format:

tasks:

  • xxx
    …

it fails with unexpected exception (AssertionError):

File “/opt/ansible/ansible/lib/ansible/playbook/helpers.py”, line 37, in load_list_of_blocks
assert isinstance(ds, (list, type(None)))
AssertionError

When it expects ds to be an list, it is actually an dict with ‘task’ key.

It involves digging into the Ansible code to know that my main.yml is malformed. I would suggest Ansible point out the syntax, or accept both format of main.yml.

In either case, I would like to send a patch for review.

2

the assumption is correct, what is incorrect is your usage of 'tasks:'
in this file, the message can be made clearer though.

3

Also, having the full traceback would be helpful.

All of those AssertionError exceptions should be caught, and the proper AnsibleParserError should be raised instead.

The catching of AssertionError should be happening in all locations where load_list_of_blocks, load_list_of_tasks and load_list_of_roles is being used.

I was unable to find any place where the AssertionError is not being caught in current devel.

4

So updated via c1add8c5e4758d2edea6e49c1b62aee614f5c4fb which now
captures the assertion error and gives out something a bit more
helpful.