some improvements for the command-action

Can I ask what is your use case for creates and removes together? It seems a little confusing and I want to understand.

I could possibly see creates and removes taking a fnmatch glob expression which might be easier than the list, I don’t know.

honestly, I needed only case, with multiple items were created. DAB utility for PROXMOX downloads package indexes for bootstrapping new container… to save time for that I check if the files are already here… in this case it is only 10 files :)… But you are right, next step, may be, will be to support glob expression…

Simplest case for using ‘creates’ and ‘removes’ at once is, if I move something on the remote machine…

I did this change with ‘removes’ only because ‘symmetry’ in code. It breaks nothing, it only extend command in expected way.

How about sending me a patch for only the glob mode?

That seems like the code would be cleaner too, and not require complex argument usage to pass the data in.

Hm… for my particular case, it will be useless :(… even with globs I need several entries for create…

What problem you see with complex removes and creates?
it is only option, it also usable in old way, it breaks nothing, and do not add any complexity in the code, as far as I can see…
To my mind, it has some logic… may be I missing some point…

I though it can be extended with globs but without loosing this option to give array as argument

Seems you would want to write a module in this case rather than using command?

Ok :slight_smile: it was just a proposal… I will use it as separate module. Anyway thanks for the comments

Yeah I have not used proxmox yet but I think there is general interest enough in making it a module, just because it’s useful to return more info, not just because I thought the command thing was a little hard to grok :slight_smile: