Rework of properties in zfs module

When development of the zfs module started there was no possibility to set check_invalid_arguments=False in the argspec and i don’t think complex args were available either so ALL zfs properties ended up being an ansible module option. This is bad because options have different names and settings on different OS’es and zpool versions.

I have a reworked version of the zfs module here: https://github.com/johanwiren/ansible-modules-extras/commit/e549d967233879981d3639c83d757bafd8274265?diff=unified

My proposal is to skip option checking in the ansible module and pass on all options to the zfs command to set/update the properties. This probably breaks some guidelines about options being documented, but I don’t see a better way of doing it.

Comments and thoughts about that?

I did not create a PR for it since I read that module owners get their PRs merged automatically, which is not intended in this case :slight_smile:

/Johan