MySQL & PostgreSQL modules feedback -- can we standardize the arguments?

Archives Ansible Project
1

Generally across ansible we use "password" vs "passwd" as an argument

Now, both these modules take TWO passwords, so they use a different variation, which is fine, but they don't vary it in the same way.

One type of module uses "loginpass" another uses "loginpasswd". (This is the password for the database, not the user)

If we can get them all to use "login_password" and "password" I think that is, despite being a little verbose, least confusing.

Similarly, anything with "twowords" should be like "two_words" anyway, since it makes it a lot easier to read.

I'm not going to make this change since I don't have a good test environment -- so this is more directed at Mark and Lorin, or others who might
have the desire and a quick way to test things.

Why I'm asking -- I need to know all the possible key names so I can tell the common logging code to not log those options, I also want to add them to the
docs page.

Sorry for being pedantic :slight_smile:

--Michael

2

The underscore is fine, but using ‘password’ instead of ‘passwd’ seems like an unnecessary step, as login_password is kinda long.

My rationale is that I like short variable names, so I normally use ‘pass’ as the name of a password. In Python, this is a reserved word, so the next best, short, variable name is ‘passwd’. Then, for consistency, I prefer if the parameters that are passed in to the module have the same names.

However I don’t care about this issue enough to take it further - I much prefer consistency in the product over having things “my way”.

So I’m ready to add the underscores and potentially change the word ‘passwd’ to ‘password’, if that’ what you prefer, just let me know.

  • Mark
3

Yeah, please do – makes the scrubber not have to check as many permutations.

– Michael

4

I’ll fix this for the PostgreSQL modules.

Lorin