Initial analysis of Extras PRs, and next steps

Archives Ansible Developer
1

OK, so I created a label called "owner_pr" for all PRs in Extras that
were submitted by the module owners. I then went through and found
all open PRs against extant modules that were submitted by the
original authors of those modules.

I found 5. :slight_smile:

On the other hand, there are *91* new module requests.

So here are some of my thoughts now:

1. I now believe we should require email and github-id in the author
field. With that data, it will be much easier to ping module authors
in the PR itself to say "hey, as the author of this module, you're the
closest thing to the 'owner' -- can you look at this PR please?"
(Which may turn up a few unresponsive maintainers. I'd be okay with
that new data.)

If anyone can think of any compelling reason *not* to add github-id to
the Author field, I'll entertain it -- and in the absence of negative
feedback in the next day or two, I think I'm just going to Just Go Do
That.

2. The process around approving new modules is more urgent than I
previously realized. Fortunately, I think there's a lot of good
communication in these modules, and some of them are modules that,
under the new policy of "accepting new modules by people who have
already written modules," would be pulled in immediately. So my next
step is to go through and tease out some more of this data. That will
be in my next report to the list.

--g

2

on 1), I think it's fine, we can even just lookup the commit that
added the module to get the github id.

on 2) I already pulled in all extras PRs (5) that I saw of a module
author that already conforms to the rules (resmo), another author
would qualify but his PRs do not seem to have adjusted yet (emonty).
I'll look over the ones you tagged after lunch and try to knock them
out.

3

Thanks Greg - it looks like you’re doing lots of work to get the extras PR flow moving :slight_smile:

@greg do you want us to update currently pending PRs with updated author info? E.g. Author: Rob White (@wimnat)

@brian when you say “already confirms to the rules”, to what rules are you referring?

4

@rob, PRs that were pending owned by module authors that already were
consistently conforming to our requirements.

5

Thanks Greg - it looks like you're doing lots of work to get the extras PR
flow moving :slight_smile:

No, the thinking is the work. This is just typing, LOL.

@greg do you want us to update currently pending PRs with updated author
info? E.g. Author: Rob White (@wimnat)

Sure, that would be great.

@brian when you say "already confirms to the rules", to what rules are you
referring?

I think he was referring to the "owner_prs" that I tagged earlier --
i.e. "PR requests to an existing module made by that module's owner."

--g