I see that new bugs are being raised against ec2_vpc.
To avoid duplicate effort against ec2_vpc and the newer vpc_net, vpc_route_table and vpc_subnet modules, can we deprecate ec2_vpc?
Good question, do we have most of it's features already in new
ec2_vpc_<sub> modules?
Also, even if we deprecate it, we should fix any glaring bugs, new
features should be stopped though.
I think it’s time for deprecation. The functionality should already be present in the new modules.
send a PR (just rename file to leading _)
The functionality should be, but isn’t present in the new modules from my perspective.
vpc_net:
No ability to modify a VPC referenced by it’s vpc_id (rather than by a list of tags)
vpc_route_table:
Doesn’t auto-choose the the type of gateway for each route based on the target type.
The existing ec2_vpc module allows creation, removal or modification of a complete VPC from a declarative description of the VPC.
The new set move things to a much more complex multi-step process
Right now, to use the new modules creating a VPC involves:
1 creating the VPC itself
2 creating each subnet (using the vpc_id from step 1)
3 creating route tables, and assigning them to the subnets (again using the subnet_id values from each of step 3)
The alternative with the older module:
1 create the VPC, subnets and route tables
2 pub
Whilst having the ability to modify one subnet after the VPC is in place is useful, standing up or tearing down VPCs is significantly more complex.
imo the new modules are complimentary to the older one (or will be once the route_tables module has a sane way to handle route targets), rather than a viable replacement.
Andy