Hi all,
I was looking at all the new notification modules and they generally appear to exit with changed=True. The except is the mail module which exits with changed=false. Initially I was thinking mail should just be updated to exit with changed=true, but now i’m not so sure… I can see an argument to be made that “changed” should represent something that’s actually changing the state on one of your systems, and just sending out an email or a chat notification shouldn’t count as “changing” anything. What do folks think?
matt
I made the jabber module returned changed=true when it sends a message,
because an action was executed (even if the system itself didn't change).
As long as we have a decision on what the standard should be, its easy to
change them all to conform one way or the other.
I believe it should not return changed=True, and should also not run in check mode.
jabber one joins server and even room but doesn't send message in check
mode, does this work?
I'll patch to return changed=False.
That sounds reasonable.
I think it shouldn’t post, seeing the message could be about it deploying something.