Creating pull requests for ansible-modules-extras

Archives Ansible Developer
1

I’ve got a fix for an outstanding issue in “ansible-modules-extras” (in one of the windows modules), and probably a few others.

However this being the first time I’ve done the Github thing to submit a patch/fix I’m a bit unsure as to how I proceed.

If I want to submit a bug fix for a module in “ansible-modules-extras”, can I commit/push this via the “extras” submodule in ansible.git (my fork), or do I need to fork “ansible-modules-extras” and commit/push changes to that before I can generate a pull request?

What’s the correct workflow here?

Thanks,
Kevin

2

Hi,

Yes, fork ansible-modules-extras and clone it to your local machine where you are doing your fixing, then create a branch off devel to put your fix in, make the change, commit it locally and then push it up to your fork. Once the new branch is pushed up to github, if you go to your github fork of ansible-modules-extras in a browser you’ll be able to create the pull request.

I suggest reading this too http://docs.ansible.com/ansible/community.html#contributing-code-features-or-bugfixes if you haven’t seen it already, and http://docs.ansible.com/ansible/developing_modules.html, and (since you mentioned windows modules - http://docs.ansible.com/ansible/developing_modules.html#windows-modules-checklist

All the best

Jon

3

Hi Jon,

Yes I read all of those “contributing” guidances but felt there was a piece of the puzzle missing for me.

So to be clear what you’re saying is:

  1. get stuff working in the context of ansible.git + “source hacking/envsetup”

  2. then copy paste your working bits over to local copy of fork of “ansible-modules-extras” and commit in my own fix branch

  3. push commit

  4. issue pull request

Apologies if I’m repeating this somewhat.

Kevin

4

Pretty much, although I’d suggest creating your fixing branch of devel first, before modifying any files, otherwise you’ll have to stash your changes so you can re-apply them to your fix branch once you are happy with them.

Jon

5

Yeah, that side of thnigs I understood, it was the submodule stuff that threw me off, never having worked with them before.

Thanks for your time Jon, much appreciated.

Kevin