Contributing: which branch to use?

Archives Ansible Developer
1

Hi all,

If I would like to make a patch for the last v1 version, which branch should I use as a base?I’m hesitating between stable_v1.9 and v1_modules …

2

What's the patch for?

3

I’d like to implement supporting the parameter ‘labels’ for the docker module.

4

I think it's unlikely that we'll backport a feature into 1.9.x unless
it's a critical bugfix at this point, which this is not.

Here's what I'd advise:

1. Look through the PRs open against the Docker module in
ansible/ansible-modules-core now. Make sure it's not a duplicate of
one of those.
2. If it's not, file it against 2.0 so we can consider getting it into devel.

--g

5

There is a PR for this for the version 2, but my production servers run ansible 1.9 and it’s unlikely that I shift to 2.0 as soon as it’s released to keep my servers stable.

Anyways, what branch should I use to base my changes on for, say, v1.9.3 ?

6

For your local changes, using 1.9.3 as your base sounds reasonable.

--g

7

actually, for any patches you hope to make it into a minor release you
should always target the stable- branch, in this case stable-1.9

8

Any chance to put it into the coming 1.9.4 ?

9

Ok, guys, I’ve pushed a PR for this on the stable-1.9. Please review.