As we are getting larger there are getting to be a lot of pull requests.
Rather than it just being me who does most of the reviews, I'd like to
get people involved that
have experience with the various other modules. For instance, some
people do a lot with EC2, some people do a lot with the database
modules, and so on. Up until now this was me saying hey @xyz or on
that wrote the module, and I want to get that opened up a little bit
-- because they really are everyone's modules.
I've already merged a large amount of the outstanding crop of pull
requests from the last week, but if folks want to look over the pull
requests and +1 ones they think are ok and have also tested, that may
be able to accelerate the pull request process a fair amount.
If something already has a bunch of +1s, you probably don't need to +1
it any more. Don't +1 something unless you have both reviewed the
code and tested it. Be sure to think about as many of the corner
cases as you can.
If you think something shouldn't be merged, just express your
questions. A "-1" or thumbs down can be considered off-putting, so
asking "what happens when XYZ?" or "It looks like when XYZ, this does
XYZ" can sometimes be nicer way of that
Over the last week and before I was holding off on merging some things
since we had a large influx of new users , and I'm going to keep
things merging on a much more routine schedule in the near future, so
there's less holding time between when something is submitted and when
you know if it's in or not.
In any event, everybody's help in reviewing is quite welcome and I
hope to get all of this nicely accelerated for the coming weeks. If
you want to be subscribed to all of the activity, go to
http://github.com/ansible/ansible and click "watch" (the button beside
the star button).
Thanks!