mercurial module needs review and feedback!

Okay. Sometimes it’s hard to catch what is 2.4 compatible or not.
Thanks.

Hey all,

I just want to tell you guys I just refactored the preview code above.
https://github.com/yeukhon/ansible/blob/cc6fc149c2bd3c0d1182088ed7a96700cbc40749/library/hg

This is cleaner, much closer to git implementation and did all the correct things. I even wrote new tests.yml playbook.
Check it out please. I heard the deadline to submit pull request is probably sometime today !

I created a test repo just for this: https://bitbucket.org/yeukhon/trash-hg
output: http://pastebin.com/cECqBPw4

Thanks

John

Hi Yeukon,

We are moving very close to the release (tomorrow).

Please go ahead and submit a pull request and let folks review it there.

I'll pull the trigger if we get a few +1s.

Thanks!

https://github.com/ansible/ansible/pull/1948
Yes. It’s already a pull request as of last reply.

Thanks for consideration and any troubles.

:slight_smile:

Yeukhon

Congrats Yeukhon! Thanks for crafting a fine module. I plan on testing it on some qa servers this week or next.

Hi Yeukhon,

I found a simple issue when updating some code… I kept getting “abort: no suitable response from remote hg!”. It took me a while to figure out I had a different default path specified in the destination’s .hg/hgrc, which wasn’t valid at all for the pull.
https://github.com/ansible/ansible/issues/1989

I’d like ability to hg pull from a repo other than the original clone location. What do you think?
I think this one was simple enough that I think I got it:
https://github.com/ansible/ansible/pull/1990

-joel

Hello !

It could be usefull to specify in the doc that mercurial should be installed
on the host before trying to use hg actions in playbooks :slight_smile: I spend some
time to found the solution to that problem :

A better way to solve this would be to make it raise a nice failure
error if hg was not in path.

We have functions in ansible module common core to assist with this.

Somebody send me a patch :slight_smile:

Sure it’ll be better to have a good error message instead of that error :slight_smile: