# zabbix\_maintenance minor improvements

**URL:** <https://forum.ansible.com/t/zabbix-maintenance-minor-improvements/16093>\
**Category:** Ansible Developer\
**Created:** [September 1, 2014, 5:39pm UTC](https://forum.ansible.com/t/zabbix-maintenance-minor-improvements/16093 "2014-09-01T17:39:16Z")\
**Posts on this page:** 4\
**Page:** 1

<div class="post-metadata">

**Author:** ![Rene\_Moser](https://avatars.discourse-cdn.com/v4/letter/r/7bcc69/32.png) [@Rene\_Moser](https://forum.ansible.com/u/Rene_Moser)\
**Post date:** [September 1, 2014, 5:39pm UTC](https://forum.ansible.com/t/zabbix-maintenance-minor-improvements/16093/1 "2014-09-01T17:39:16Z")

</div>

Hi

I just made a PR [https://github.com/ansible/ansible/pull/8841](https://github.com/ansible/ansible/pull/8841) for a minor improvment in this new module. Since this module is in devel only, I wanted to ask if those changes could make it in final 1.8.

I made 2 rather smal commitsl, which help me with the daily work with this module. The first commit defaults the `state` option to `present` which is the default for many (all?) modules I saw having this argument.

The second change helps me saving time by providing the login data once in environment variables, but you can also still provide them with args like before the change, or mix them. Regarding in the future, I also wanted to have more zabbix modules, e.g. zabbix\_host for adding new hosts, which can make use of those variables too.

Thanks for your time and work.

Regads  
René

---

<div class="post-metadata">

**Author:** ![Rene\_Moser](https://avatars.discourse-cdn.com/v4/letter/r/7bcc69/32.png) [@Rene\_Moser](https://forum.ansible.com/u/Rene_Moser)\
**Post date:** [September 5, 2014, 9:11am UTC](https://forum.ansible.com/t/zabbix-maintenance-minor-improvements/16093/2 "2014-09-05T09:11:08Z")

</div>

Just wanted to let you know I rebased the PR to make the change looks more logical and understandable. These commits does not change the existing functionality, even though the module is new in 1.8.

Would be glad if it could make it into 1.8.

---

<div class="post-metadata">

**Author:** ![Rene\_Moser](https://avatars.discourse-cdn.com/v4/letter/r/7bcc69/32.png) [@Rene\_Moser](https://forum.ansible.com/u/Rene_Moser)\
**Post date:** [September 15, 2014, 12:00pm UTC](https://forum.ansible.com/t/zabbix-maintenance-minor-improvements/16093/3 "2014-09-15T12:00:27Z")

</div>

Hi

---

<div class="post-metadata">

**Author:** ![Michael\_DeHaan1](https://avatars.discourse-cdn.com/v4/letter/m/5e9695/32.png) [@Michael\_DeHaan1](https://forum.ansible.com/u/Michael_DeHaan1)\
**Post date:** [September 22, 2014, 6:24pm UTC](https://forum.ansible.com/t/zabbix-maintenance-minor-improvements/16093/4 "2014-09-22T18:24:36Z")

</div>

Hi Rene,

Thanks for the contribution.

You’re in queue, but we are currently tackling P1 and P2 items before moving to P3s and so on.

I can’t make any promises on 1.8, but please stay tuned.

Thanks!