# Trying to create PR to devel branch for new module **URL:** \ **Category:** Ansible Developer\ **Created:** [December 8, 2016, 11:48am UTC](https://forum.ansible.com/t/trying-to-create-pr-to-devel-branch-for-new-module/23199 "2016-12-08T11:48:22Z")\ **Posts on this page:** 7\ **Page:** 1
**Author:** ![Pieter\_Voet](https://avatars.discourse-cdn.com/v4/letter/p/5fc32e/32.png) [@Pieter\_Voet](https://forum.ansible.com/u/Pieter_Voet)\ **Post date:** [December 8, 2016, 11:48am UTC](https://forum.ansible.com/t/trying-to-create-pr-to-devel-branch-for-new-module/23199/1 "2016-12-08T11:48:22Z")
Hi all, I wrote a new module that can add a variable to ‘extra-vars’ from within a play. All logic executes locally, so this module actually is an action plugin. But that also requires a ‘stub’ module in ‘modules/core/logic’… I verified my code against the latest ‘devel’ version and also ran tests from ‘test’. No failures. In fact, I already created a pull-request against the ansible 2.1-stable branch, but that PR was closed since that stable version does not accept new features anymore. I modified my code to work with the latest devel branch. so, I forked ‘ansible’ and ‘ansible-modules-core’ and commited my changes to my forked ‘devel’ branch, i.e. I committed code to my ‘devel’ ansible branch, and the ‘stub’ module ( dunno if this is correctly described… it’s like the ‘set\_fact’ module; there just needs to be a file for the module in ‘modules/core/logic’…) to my ansible-modules-core fork. Then I created two pull requests; one for ‘ansible devel’ and one for ‘ansible-modules-core devel’… These are the same steps I took for the ‘2.1-stable’ PRs… Those PR’s were verified correctly by the Shippable tooling, but with the ‘devel’ branch it fails : for ‘ansible devel’ the console build\_ci step says : lib/ansible/modules/extras 2016-12-08 09:43:43 ============================================================================ 2016-12-08 09:43:43 ERROR: Ansible module subdirectories must contain an **init**.py 2016-12-08 09:43:43 2016-12-08 09:43:43 ============================================================================ 2016-12-08 09:43:43 lib/ansible/modules/core 2016-12-08 09:43:43 ============================================================================ 2016-12-08 09:43:43 ERROR: Ansible module subdirectories must contain an **init**.py and for ‘ansible-modules-core’ the console says : Logs are not available. I think this might be caused by the split in code between ‘ansible’ and its modules… If I look in my forked branch, then ‘lib/ansible/modules’ contains the ‘core’ and ‘extras’ directories as some sort of links… I don’t get how this is set up… If run the test on my local clone without anything in the ‘lib/ansible/modules/core’ directories, I obviously get the ‘subdirectories must contain an **init**.py’ error. That makes sense. But something has changed apparently, since the same PR’s for 2.1-stable did not run into this failure… Question is : how do I create the pull requests for this feature request ? Thanks in advance… ---
**Author:** ![Tobias\_Wolf](https://avatars.discourse-cdn.com/v4/letter/t/eada6e/32.png) [@Tobias\_Wolf](https://forum.ansible.com/u/Tobias_Wolf)\ **Post date:** [December 8, 2016, 2:47pm UTC](https://forum.ansible.com/t/trying-to-create-pr-to-devel-branch-for-new-module/23199/2 "2016-12-08T14:47:39Z")
I would wait a bit for the repository to be back in a good state. And then you can make a pull request in _one_ repo. They were all merged yesterday but got messed up a bit. Read the “Subject: IMPORTANT …” mail … ---
**Author:** ![Pieter\_Voet](https://avatars.discourse-cdn.com/v4/letter/p/5fc32e/32.png) [@Pieter\_Voet](https://forum.ansible.com/u/Pieter_Voet)\ **Post date:** [December 8, 2016, 3:46pm UTC](https://forum.ansible.com/t/trying-to-create-pr-to-devel-branch-for-new-module/23199/3 "2016-12-08T15:46:03Z")
Thanks Tobias… do you recommend to delete the previous PR’s then ? ---
**Author:** ![Pieter\_Voet](https://avatars.discourse-cdn.com/v4/letter/p/5fc32e/32.png) [@Pieter\_Voet](https://forum.ansible.com/u/Pieter_Voet)\ **Post date:** [December 8, 2016, 4:22pm UTC](https://forum.ansible.com/t/trying-to-create-pr-to-devel-branch-for-new-module/23199/4 "2016-12-08T16:22:14Z")
Never mind… I decided to close the previous created PRs, and create a new one… Thanks. ---
**Author:** ![Pieter\_Voet](https://avatars.discourse-cdn.com/v4/letter/p/5fc32e/32.png) [@Pieter\_Voet](https://forum.ansible.com/u/Pieter_Voet)\ **Post date:** [December 8, 2016, 4:47pm UTC](https://forum.ansible.com/t/trying-to-create-pr-to-devel-branch-for-new-module/23199/5 "2016-12-08T16:47:42Z")
After creating a new PR, one of the Shippable tests fails with : ERROR: Timeout waiting for freebsd/10.3-STABLE instance 438fa7cc-b055-4353-a1ca-cd7174ad8895. which obviously is something that is not caused by my code… There are other PR’s created were all tests passed. Do I need to be a bit more patient ? How do I restart the tests for my PR ? Or will that be done automatically ? Thanks in advance… ---
**Author:** ![Tobias\_Wolf](https://avatars.discourse-cdn.com/v4/letter/t/eada6e/32.png) [@Tobias\_Wolf](https://forum.ansible.com/u/Tobias_Wolf)\ **Post date:** [December 8, 2016, 11:56pm UTC](https://forum.ansible.com/t/trying-to-create-pr-to-devel-branch-for-new-module/23199/6 "2016-12-08T23:56:33Z")
When you force push to the PR the tests are run again. ---
**Author:** ![Pieter\_Voet](https://avatars.discourse-cdn.com/v4/letter/p/5fc32e/32.png) [@Pieter\_Voet](https://forum.ansible.com/u/Pieter_Voet)\ **Post date:** [December 9, 2016, 11:40am UTC](https://forum.ansible.com/t/trying-to-create-pr-to-devel-branch-for-new-module/23199/7 "2016-12-09T11:40:14Z")
OK, PR submitted successfully now. Thanks for the response.