# Reviews needed for 99 new modules in Ansible Extras

**URL:** <https://forum.ansible.com/t/reviews-needed-for-99-new-modules-in-ansible-extras/18524>\
**Category:** Ansible Project\
**Created:** [June 16, 2015, 9:08pm UTC](https://forum.ansible.com/t/reviews-needed-for-99-new-modules-in-ansible-extras/18524 "2015-06-16T21:08:50Z")\
**Posts on this page:** 7\
**Page:** 1

<div class="post-metadata">

**Author:** ![Greg\_DeKoenigsberg1](https://avatars.discourse-cdn.com/v4/letter/g/838e76/32.png) [@Greg\_DeKoenigsberg1](https://forum.ansible.com/u/Greg_DeKoenigsberg1)\
**Post date:** [June 16, 2015, 9:08pm UTC](https://forum.ansible.com/t/reviews-needed-for-99-new-modules-in-ansible-extras/18524/1 "2015-06-16T21:08:50Z")

</div>

We currently have 99 new modules in Ansible Extras that need review.  
You can see the list here:

[https://github.com/ansible/ansible-modules-extras/labels/new\_module](https://github.com/ansible/ansible-modules-extras/labels/new_module)

If you are a module author yourself (official list:  
[https://github.com/ansible/ansible-modules-extras/blob/devel/REVIEWERS.md](https://github.com/ansible/ansible-modules-extras/blob/devel/REVIEWERS.md)),  
please take the time to review one of these modules. The process is  
simple:

1. Go to the pull request URL and leave a note that you’re in the  
process of reviewing the module.  
2. Run the module to test its basic functionality.  
3. Review the module for its adherence to the module guidelines.  
([http://docs.ansible.com/developing\_modules.html#module-checklist](http://docs.ansible.com/developing_modules.html#module-checklist)).  
4. Add any necessary feedback to the pull request.  
5. Once the module looks good, give it a +1!

Any module with two +1s from official module reviewers will be  
approved for inclusion in Ansible Extras.

Thanks for your help in improving the PR merge process. If you have  
any feedback, comments or questions, please don't hesitate to ask.

--g

---

<div class="post-metadata">

**Author:** ![Barry\_Kaplan](https://avatars.discourse-cdn.com/v4/letter/b/48db29/32.png) [@Barry\_Kaplan](https://forum.ansible.com/u/Barry_Kaplan)\
**Post date:** [June 17, 2015, 12:59am UTC](https://forum.ansible.com/t/reviews-needed-for-99-new-modules-in-ansible-extras/18524/2 "2015-06-17T00:59:47Z")

</div>

This is an impressive set of extensions.

A question, when a modules has in its docs, eg

requirements: [datadog]

That implies the need for ‘pip install datadog’? Not a requirement for a datadog role  
that includes the python library?

---

<div class="post-metadata">

**Author:** ![Brian\_Coca](https://avatars.discourse-cdn.com/v4/letter/b/6de8d8/32.png) [@Brian\_Coca](https://forum.ansible.com/u/Brian_Coca)\
**Post date:** [June 17, 2015, 12:48pm UTC](https://forum.ansible.com/t/reviews-needed-for-99-new-modules-in-ansible-extras/18524/3 "2015-06-17T12:48:39Z")

</div>

modules cannot depend on roles, it should always be libraries (or  
versions of python).

---

<div class="post-metadata">

**Author:** ![roshan\_wanaskar](https://avatars.discourse-cdn.com/v4/letter/r/c2a13f/32.png) [@roshan\_wanaskar](https://forum.ansible.com/u/roshan_wanaskar)\
**Post date:** [December 3, 2018, 5:28am UTC](https://forum.ansible.com/t/reviews-needed-for-99-new-modules-in-ansible-extras/18524/4 "2018-12-03T05:28:16Z")

</div>

What are the test required if I want to add Module in Cloud Module Directory. and what is the process to review module? Which of these tests are required among Units, Integration, Sanity and Compile/

---

<div class="post-metadata">

**Author:** ![Naval](https://avatars.discourse-cdn.com/v4/letter/n/51bf81/32.png) [@Naval](https://forum.ansible.com/u/Naval)\
**Post date:** [December 4, 2018, 1:15pm UTC](https://forum.ansible.com/t/reviews-needed-for-99-new-modules-in-ansible-extras/18524/5 "2018-12-04T13:15:42Z")

</div>

Hi Roshan,

Sanity and Compile are must. Depending on modules units and integration are optional, not sure about Cloud module.

Thanks  
Naval

---

<div class="post-metadata">

**Author:** ![roshan\_wanaskar](https://avatars.discourse-cdn.com/v4/letter/r/c2a13f/32.png) [@roshan\_wanaskar](https://forum.ansible.com/u/roshan_wanaskar)\
**Post date:** [December 5, 2018, 8:02am UTC](https://forum.ansible.com/t/reviews-needed-for-99-new-modules-in-ansible-extras/18524/6 "2018-12-05T08:02:57Z")

</div>

Hi Naval,

I am working on 1 PR request which has stale\_ci tag and got “All checks have passed” through shippable Devops, what does that mean?

I have done all sanity and compile test locally. What should I do now to merge it to Ansible Directory?  
PR #44256

Please help…Thanks in advance

Roshan

---

<div class="post-metadata">

**Author:** ![Naval](https://avatars.discourse-cdn.com/v4/letter/n/51bf81/32.png) [@Naval](https://forum.ansible.com/u/Naval)\
**Post date:** [December 5, 2018, 10:46am UTC](https://forum.ansible.com/t/reviews-needed-for-99-new-modules-in-ansible-extras/18524/7 "2018-12-05T10:46:07Z")

</div>

Hi Roshan,

Get familiar with ansible bot,

[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)  
put bot\_status in comment.

bot\_status will give you detail about files in your commit and who are maintainers of those files.

Once you are done with review comment,  
put ready\_for\_review in comment.

I will recommend you to join ansible-devel group irc-chat, you can get answer there.

–Naval
