# PR best practices

**URL:** <https://forum.ansible.com/t/pr-best-practices/23626>\
**Category:** Ansible Project\
**Created:** [February 3, 2017, 12:55am UTC](https://forum.ansible.com/t/pr-best-practices/23626 "2017-02-03T00:55:28Z")\
**Posts on this page:** 2\
**Page:** 1

<div class="post-metadata">

**Author:** ![Serghei\_Anicheev](https://avatars.discourse-cdn.com/v4/letter/s/3bc359/32.png) [@Serghei\_Anicheev](https://forum.ansible.com/u/Serghei_Anicheev)\
**Post date:** [February 3, 2017, 12:55am UTC](https://forum.ansible.com/t/pr-best-practices/23626/1 "2017-02-03T00:55:28Z")

</div>

Hey everyone!

I just finished writing several modules for ansible.  
However i would like to organize my PR correctly.  
So here is the question:

- Should it be within single PR or should i break it into part for each module?

Best Regards

---

<div class="post-metadata">

**Author:** ![Brian\_Coca](https://avatars.discourse-cdn.com/v4/letter/b/6de8d8/32.png) [@Brian\_Coca](https://forum.ansible.com/u/Brian_Coca)\
**Post date:** [February 6, 2017, 5:09pm UTC](https://forum.ansible.com/t/pr-best-practices/23626/2 "2017-02-06T17:09:34Z")

</div>

One per module, I also recommend you just submit the first module and  
iterate with the reviewer, once that is merged you should have better  
idea of what we look for and make subsequent module merging much  
smoother.