# Pending to get reviewed, approved, and merged

**URL:** <https://forum.ansible.com/t/pending-to-get-reviewed-approved-and-merged/28010>\
**Category:** Ansible Developer\
**Created:** [July 10, 2018, 3:27pm UTC](https://forum.ansible.com/t/pending-to-get-reviewed-approved-and-merged/28010 "2018-07-10T15:27:17Z")\
**Posts on this page:** 8\
**Page:** 1

<div class="post-metadata">

**Author:** ![samir.musali](https://avatars.discourse-cdn.com/v4/letter/s/bc8723/32.png) [@samir.musali](https://forum.ansible.com/u/samir.musali)\
**Post date:** [July 10, 2018, 3:27pm UTC](https://forum.ansible.com/t/pending-to-get-reviewed-approved-and-merged/28010/1 "2018-07-10T15:27:17Z")

</div>

Hi.

It has been almost 2 months since my pull request submission onto Ansible about new callback plugin: [https://github.com/ansible/ansible/pull/40296/commits/f85252ddd64e1d95526705f2c50dcfa172395b73](https://github.com/ansible/ansible/pull/40296/commits/f85252ddd64e1d95526705f2c50dcfa172395b73)

I see the labels saying it will be added to Ansible 2.6 but Ansible 2.6 Community Freeze passed more than a month ago but still nobody touches it or says anything.

---

<div class="post-metadata">

**Author:** ![system](https://us1.discourse-cdn.com/ansible/original/1X/1882d9a01da5d8996a862359b0913cc568a39b84.svg) [@system](https://forum.ansible.com/u/system)\
**Post date:** [July 10, 2018, 3:38pm UTC](https://forum.ansible.com/t/pending-to-get-reviewed-approved-and-merged/28010/2 "2018-07-10T15:38:53Z")

</div>

Hi,

first of all, sorry for the wait.

To clarify, there is no label for 'will be added in 2.6' .. the  
'affects 2.6' is a 'guess' by the bot to know which versions are  
affected by an issue, not a guarantee of when it will be merged.

You can prod us here or in irc to ensure we get back to your PR, but  
the core team does not normally deal with 'community' plugins and most  
people that do are volunteers on their free time, so I ask for  
patience and perseverance.

Also I see you didn't address the issue with the version\_added value  
and another that no one caught in review, updates in ticket.

---

<div class="post-metadata">

**Author:** ![samir.musali](https://avatars.discourse-cdn.com/v4/letter/s/bc8723/32.png) [@samir.musali](https://forum.ansible.com/u/samir.musali)\
**Post date:** [July 10, 2018, 6:38pm UTC](https://forum.ansible.com/t/pending-to-get-reviewed-approved-and-merged/28010/3 "2018-07-10T18:38:13Z")

</div>

Hey Brian,

Thanks for the clarification!

I have already made the changes you requested except one - please, re-review the changes and if possible, make modifications to my Pull Request since I could not figure out how to use Ansible JSON Encoder.

Thanks in advance!

---

<div class="post-metadata">

**Author:** ![samir.musali](https://avatars.discourse-cdn.com/v4/letter/s/bc8723/32.png) [@samir.musali](https://forum.ansible.com/u/samir.musali)\
**Post date:** [July 10, 2018, 9:29pm UTC](https://forum.ansible.com/t/pending-to-get-reviewed-approved-and-merged/28010/4 "2018-07-10T21:29:48Z")

</div>

Sorry for bothering again but can you take a look at it again? I have made changes again

---

<div class="post-metadata">

**Author:** ![samir.musali](https://avatars.discourse-cdn.com/v4/letter/s/bc8723/32.png) [@samir.musali](https://forum.ansible.com/u/samir.musali)\
**Post date:** [July 11, 2018, 2:06pm UTC](https://forum.ansible.com/t/pending-to-get-reviewed-approved-and-merged/28010/5 "2018-07-11T14:06:36Z")

</div>

Hey, can you review the changes and retrigger Shippable? I can see only one failure which has time-out error which is gonna be gone in the newer run. There is no error in code.

---

<div class="post-metadata">

**Author:** ![samir.musali](https://avatars.discourse-cdn.com/v4/letter/s/bc8723/32.png) [@samir.musali](https://forum.ansible.com/u/samir.musali)\
**Post date:** [July 11, 2018, 2:46pm UTC](https://forum.ansible.com/t/pending-to-get-reviewed-approved-and-merged/28010/6 "2018-07-11T14:46:10Z")

</div>

Thanks, man! It passed all tests and I think, based on your approval of my changes, it’s ready to be merged, right?

---

<div class="post-metadata">

**Author:** ![samir.musali](https://avatars.discourse-cdn.com/v4/letter/s/bc8723/32.png) [@samir.musali](https://forum.ansible.com/u/samir.musali)\
**Post date:** [July 11, 2018, 7:56pm UTC](https://forum.ansible.com/t/pending-to-get-reviewed-approved-and-merged/28010/7 "2018-07-11T19:56:05Z")

</div>

Thanks for all, Brian! Just final question I have - when is this logdna plugin going to be available to users? In next update of v2.6 or in v2.7? When do you think it is going to be released?

Thanks for all!

---

<div class="post-metadata">

**Author:** ![system](https://us1.discourse-cdn.com/ansible/original/1X/1882d9a01da5d8996a862359b0913cc568a39b84.svg) [@system](https://forum.ansible.com/u/system)\
**Post date:** [July 11, 2018, 7:57pm UTC](https://forum.ansible.com/t/pending-to-get-reviewed-approved-and-merged/28010/8 "2018-07-11T19:57:20Z")

</div>

We release new features in major releases 2.X, for minor releases  
(2.x.y) we only do bugfixes, so at best this is 2.7.