# New NetworkManager module PR#482: What are the next steps to getting it merged?

**URL:** <https://forum.ansible.com/t/new-networkmanager-module-pr-482-what-are-the-next-steps-to-getting-it-merged/18230>\
**Category:** Ansible Developer\
**Created:** [May 14, 2015, 1:50pm UTC](https://forum.ansible.com/t/new-networkmanager-module-pr-482-what-are-the-next-steps-to-getting-it-merged/18230 "2015-05-14T13:50:51Z")\
**Posts on this page:** 4\
**Page:** 1

<div class="post-metadata">

**Author:** ![chlong](https://avatars.discourse-cdn.com/v4/letter/c/41988e/32.png) [@chlong](https://forum.ansible.com/u/chlong)\
**Post date:** [May 14, 2015, 1:50pm UTC](https://forum.ansible.com/t/new-networkmanager-module-pr-482-what-are-the-next-steps-to-getting-it-merged/18230/1 "2015-05-14T13:50:51Z")

</div>

Hi All.

I’ve submitted my first PR for a new module and it has been tagged with ‘feature\_pull\_request’ ‘new\_module’ ‘P3’ and has a green tick. What’s the next step in the process for that PR to get merged?

Cheers  
Chris Long

---

<div class="post-metadata">

**Author:** ![Greg\_DeKoenigsberg1](https://avatars.discourse-cdn.com/v4/letter/g/838e76/32.png) [@Greg\_DeKoenigsberg1](https://forum.ansible.com/u/Greg_DeKoenigsberg1)\
**Post date:** [May 14, 2015, 2:14pm UTC](https://forum.ansible.com/t/new-networkmanager-module-pr-482-what-are-the-next-steps-to-getting-it-merged/18230/2 "2015-05-14T14:14:34Z")

</div>

Looks like bcoca is already reviewing it and providing some feedback.  
Next step is to fix the issues he's pointing out. 🙂

--g

---

<div class="post-metadata">

**Author:** ![chlong](https://avatars.discourse-cdn.com/v4/letter/c/41988e/32.png) [@chlong](https://forum.ansible.com/u/chlong)\
**Post date:** [May 15, 2015, 3:22am UTC](https://forum.ansible.com/t/new-networkmanager-module-pr-482-what-are-the-next-steps-to-getting-it-merged/18230/3 "2015-05-15T03:22:41Z")

</div>

Thanks for the response Greg.

You're correct, bcoca has reviewed it and I've fixed the issues as per his suggestions now. PR has been repushed.

Thanks too, bcoca.

Cheers

Chris Long  
Snr Systems Engineer,  
PnT Developer Operations SysOps Team  
Red Hat, Australia  
Ph: +61735147148  
Mobile: +61402919942

"Do what you love doing, with people who you like being with, to the overall benefit of society - build individual and collective wealth in the team."

---

<div class="post-metadata">

**Author:** ![chlong](https://avatars.discourse-cdn.com/v4/letter/c/41988e/32.png) [@chlong](https://forum.ansible.com/u/chlong)\
**Post date:** [May 18, 2015, 6:19am UTC](https://forum.ansible.com/t/new-networkmanager-module-pr-482-what-are-the-next-steps-to-getting-it-merged/18230/4 "2015-05-18T06:19:42Z")

</div>

Can this be merged now please? I have completed the corrections 🙂

Cheers

Chris Long