# MySQL & PostgreSQL modules feedback -- can we standardize the arguments?

**URL:** <https://forum.ansible.com/t/mysql-postgresql-modules-feedback-can-we-standardize-the-arguments/11737>\
**Category:** Ansible Project\
**Created:** [July 28, 2012, 12:59pm UTC](https://forum.ansible.com/t/mysql-postgresql-modules-feedback-can-we-standardize-the-arguments/11737 "2012-07-28T12:59:47Z")\
**Posts on this page:** 4\
**Page:** 1

<div class="post-metadata">

**Author:** ![Michael\_DeHaan](https://avatars.discourse-cdn.com/v4/letter/m/c4cdca/32.png) [@Michael\_DeHaan](https://forum.ansible.com/u/Michael_DeHaan)\
**Post date:** [July 28, 2012, 12:59pm UTC](https://forum.ansible.com/t/mysql-postgresql-modules-feedback-can-we-standardize-the-arguments/11737/1 "2012-07-28T12:59:47Z")

</div>

Generally across ansible we use "password" vs "passwd" as an argument

Now, both these modules take TWO passwords, so they use a different variation, which is fine, but they don't vary it in the same way.

One type of module uses "loginpass" another uses "loginpasswd". (This is the password for the database, not the user)

If we can get them all to use "login\_password" and "password" I think that is, despite being a little verbose, least confusing.

Similarly, anything with "twowords" should be like "two\_words" anyway, since it makes it a lot easier to read.

I'm not going to make this change since I don't have a good test environment -- so this is more directed at Mark and Lorin, or others who might  
have the desire and a quick way to test things.

Why I'm asking -- I need to know all the possible key names so I can tell the common logging code to not log those options, I also want to add them to the  
docs page.

Sorry for being pedantic 🙂

--Michael

---

<div class="post-metadata">

**Author:** ![Mark\_Theunissen](https://avatars.discourse-cdn.com/v4/letter/m/898d66/32.png) [@Mark\_Theunissen](https://forum.ansible.com/u/Mark_Theunissen)\
**Post date:** [July 28, 2012, 6:14pm UTC](https://forum.ansible.com/t/mysql-postgresql-modules-feedback-can-we-standardize-the-arguments/11737/2 "2012-07-28T18:14:07Z")

</div>

The underscore is fine, but using ‘password’ instead of ‘passwd’ seems like an unnecessary step, as login\_password is kinda long.

My rationale is that I like short variable names, so I normally use ‘pass’ as the name of a password. In Python, this is a reserved word, so the next best, short, variable name is ‘passwd’. Then, for consistency, I prefer if the parameters that are passed in to the module have the same names.

However I don’t care about this issue enough to take it further - I much prefer consistency in the product over having things “my way”.

So I’m ready to add the underscores and potentially change the word ‘passwd’ to ‘password’, if that’ what you prefer, just let me know.

- Mark

---

<div class="post-metadata">

**Author:** ![Michael\_DeHaan](https://avatars.discourse-cdn.com/v4/letter/m/c4cdca/32.png) [@Michael\_DeHaan](https://forum.ansible.com/u/Michael_DeHaan)\
**Post date:** [July 28, 2012, 6:48pm UTC](https://forum.ansible.com/t/mysql-postgresql-modules-feedback-can-we-standardize-the-arguments/11737/3 "2012-07-28T18:48:08Z")

</div>

Yeah, please do – makes the scrubber not have to check as many permutations.

– Michael

---

<div class="post-metadata">

**Author:** ![Lorin\_Hochstein1](https://avatars.discourse-cdn.com/v4/letter/l/ce73a5/32.png) [@Lorin\_Hochstein1](https://forum.ansible.com/u/Lorin_Hochstein1)\
**Post date:** [July 29, 2012, 11:28am UTC](https://forum.ansible.com/t/mysql-postgresql-modules-feedback-can-we-standardize-the-arguments/11737/4 "2012-07-29T11:28:35Z")

</div>

I’ll fix this for the PostgreSQL modules.

Lorin