# mercurial module needs review and feedback! **URL:** \ **Category:** Ansible Project\ **Created:** [January 13, 2013, 2:03am UTC](https://forum.ansible.com/t/mercurial-module-needs-review-and-feedback/12200 "2013-01-13T02:03:41Z")\ **Posts on this page:** 9\ **Page:** 3
**Author:** ![John\_Wong](https://avatars.discourse-cdn.com/v4/letter/j/6f9a4e/32.png) [@John\_Wong](https://forum.ansible.com/u/John_Wong)\ **Post date:** [January 30, 2013, 12:24am UTC](https://forum.ansible.com/t/mercurial-module-needs-review-and-feedback/12200/41 "2013-01-30T00:24:13Z")
Okay. Sometimes it’s hard to catch what is 2.4 compatible or not. Thanks. ---
**Author:** ![John\_Wong](https://avatars.discourse-cdn.com/v4/letter/j/6f9a4e/32.png) [@John\_Wong](https://forum.ansible.com/u/John_Wong)\ **Post date:** [January 31, 2013, 7:32am UTC](https://forum.ansible.com/t/mercurial-module-needs-review-and-feedback/12200/42 "2013-01-31T07:32:41Z")
Hey all, I just want to tell you guys I just refactored the preview code above. [https://github.com/yeukhon/ansible/blob/cc6fc149c2bd3c0d1182088ed7a96700cbc40749/library/hg](https://github.com/yeukhon/ansible/blob/cc6fc149c2bd3c0d1182088ed7a96700cbc40749/library/hg) This is cleaner, much closer to git implementation and did all the correct things. I even wrote new tests.yml playbook. Check it out please. I heard the deadline to submit pull request is probably sometime today ! I created a test repo just for this: [https://bitbucket.org/yeukhon/trash-hg](https://bitbucket.org/yeukhon/trash-hg) output: [http://pastebin.com/cECqBPw4](http://pastebin.com/cECqBPw4) Thanks John ---
**Author:** ![Michael\_DeHaan](https://avatars.discourse-cdn.com/v4/letter/m/c4cdca/32.png) [@Michael\_DeHaan](https://forum.ansible.com/u/Michael_DeHaan)\ **Post date:** [January 31, 2013, 12:33pm UTC](https://forum.ansible.com/t/mercurial-module-needs-review-and-feedback/12200/43 "2013-01-31T12:33:09Z")
Hi Yeukon, We are moving very close to the release (tomorrow). Please go ahead and submit a pull request and let folks review it there. I'll pull the trigger if we get a few +1s. Thanks! ---
**Author:** ![John\_Wong](https://avatars.discourse-cdn.com/v4/letter/j/6f9a4e/32.png) [@John\_Wong](https://forum.ansible.com/u/John_Wong)\ **Post date:** [January 31, 2013, 5:16pm UTC](https://forum.ansible.com/t/mercurial-module-needs-review-and-feedback/12200/44 "2013-01-31T17:16:39Z")
[https://github.com/ansible/ansible/pull/1948](https://github.com/ansible/ansible/pull/1948) Yes. It’s already a pull request as of last reply. Thanks for consideration and any troubles. 🙂 Yeukhon ---
**Author:** ![Brad\_Olson](https://avatars.discourse-cdn.com/v4/letter/b/779978/32.png) [@Brad\_Olson](https://forum.ansible.com/u/Brad_Olson)\ **Post date:** [February 2, 2013, 10:07pm UTC](https://forum.ansible.com/t/mercurial-module-needs-review-and-feedback/12200/45 "2013-02-02T22:07:11Z")
Congrats Yeukhon! Thanks for crafting a fine module. I plan on testing it on some qa servers this week or next. ---
**Author:** ![Joel\_Roller](https://avatars.discourse-cdn.com/v4/letter/j/90ced4/32.png) [@Joel\_Roller](https://forum.ansible.com/u/Joel_Roller)\ **Post date:** [February 4, 2013, 11:30pm UTC](https://forum.ansible.com/t/mercurial-module-needs-review-and-feedback/12200/46 "2013-02-04T23:30:17Z")
Hi Yeukhon, I found a simple issue when updating some code… I kept getting “abort: no suitable response from remote hg!”. It took me a while to figure out I had a different default path specified in the destination’s .hg/hgrc, which wasn’t valid at all for the pull. [https://github.com/ansible/ansible/issues/1989](https://github.com/ansible/ansible/issues/1989) I’d like ability to hg pull from a repo other than the original clone location. What do you think? I think this one was simple enough that I think I got it: [https://github.com/ansible/ansible/pull/1990](https://github.com/ansible/ansible/pull/1990) -joel ---
**Author:** ![Michael\_DeHaan](https://avatars.discourse-cdn.com/v4/letter/m/c4cdca/32.png) [@Michael\_DeHaan](https://forum.ansible.com/u/Michael_DeHaan)\ **Post date:** [February 27, 2013, 8:39pm UTC](https://forum.ansible.com/t/mercurial-module-needs-review-and-feedback/12200/47 "2013-02-27T20:39:13Z")
> Hello ! > > It could be usefull to specify in the doc that mercurial should be installed > on the host before trying to use hg actions in playbooks 🙂 I spend some > time to found the solution to that problem : A better way to solve this would be to make it raise a nice failure error if hg was not in path. We have functions in ansible module common core to assist with this. Somebody send me a patch 🙂 ---
**Author:** ![John\_Wong](https://avatars.discourse-cdn.com/v4/letter/j/6f9a4e/32.png) [@John\_Wong](https://forum.ansible.com/u/John_Wong)\ **Post date:** [February 27, 2013, 11:43pm UTC](https://forum.ansible.com/t/mercurial-module-needs-review-and-feedback/12200/48 "2013-02-27T23:43:34Z")
---
**Author:** ![Matthieu\_BIENVENUE](https://avatars.discourse-cdn.com/v4/letter/m/b77776/32.png) [@Matthieu\_BIENVENUE](https://forum.ansible.com/u/Matthieu_BIENVENUE)\ **Post date:** [February 28, 2013, 8:05am UTC](https://forum.ansible.com/t/mercurial-module-needs-review-and-feedback/12200/49 "2013-02-28T08:05:37Z")
Sure it’ll be better to have a good error message instead of that error 🙂 [Previous page](https://forum.ansible.com/t/mercurial-module-needs-review-and-feedback/12200.md?page=2)