# JBoss module enhancements PR

**URL:** <https://forum.ansible.com/t/jboss-module-enhancements-pr/24901>\
**Category:** Ansible Developer\
**Created:** [July 5, 2017, 1:44pm UTC](https://forum.ansible.com/t/jboss-module-enhancements-pr/24901 "2017-07-05T13:44:13Z")\
**Posts on this page:** 18\
**Page:** 1

<div class="post-metadata">

**Author:** ![wrefvem](https://avatars.discourse-cdn.com/v4/letter/w/f6c823/32.png) [@wrefvem](https://forum.ansible.com/u/wrefvem)\
**Post date:** [July 5, 2017, 1:44pm UTC](https://forum.ansible.com/t/jboss-module-enhancements-pr/24901/1 "2017-07-05T13:44:13Z")

</div>

Hi all–

I’ve submitted a [PR](https://github.com/ansible/ansible/pull/26379) that contains enhancements to the JBoss module that have been kicked around in the JBoss/Ansible community (there are dozens of us!!). If someone can take a look and give me some feedback, I’d be most grateful. Ansible has the potential to help a lot of JBoss shops that want to tighten up their development cycle but aren’t ready to drink the DevOps kool-aid yet. In order to unlock that potential, we need more features in the JBoss module.

At this juncture, the JBoss module only supports deployment/undeployment via the filesystem using the deployment scanner (a JBoss service that scans a particular fs directory for deployable files and deploys them). This means it either adds or removes a deployment artifact (e.g., a .war file) to a specified deployment directory. In older versions of JBoss, this was the only way to do hot deployments, but starting with JBoss 7, users have the option of using a provided CLI as well as an HTTP interface in addition to the fs method. The fs method is not recommended for production use.

So as a first step towards enhancing the JBoss module, I’ve added support for deploying via the HTTP API and the CLI. Some of us have also talked about a facts module, possibly using [jolokia](https://jolokia.org/) to gather detailed data on JBoss environments. A jolokia module could also extend deployment capabilities to other Java environments, since it’s not specific to JBoss.

Thanks!

---

<div class="post-metadata">

**Author:** ![Jairo\_Junior](https://avatars.discourse-cdn.com/v4/letter/j/8c91f0/32.png) [@Jairo\_Junior](https://forum.ansible.com/u/Jairo_Junior)\
**Post date:** [July 5, 2017, 7:40pm UTC](https://forum.ansible.com/t/jboss-module-enhancements-pr/24901/2 "2017-07-05T19:40:29Z")

</div>

Hi,

I think we’re working on something very similar: [https://github.com/ansible/ansible/pull/25422](https://github.com/ansible/ansible/pull/25422)

I was discussing this PR at #ansible-devel (IRC) instead of the devel list, but I believe we could contribute to each other work or even combine efforts. (:

---

<div class="post-metadata">

**Author:** ![Greg\_DeKoenigsberg1](https://avatars.discourse-cdn.com/v4/letter/g/838e76/32.png) [@Greg\_DeKoenigsberg1](https://forum.ansible.com/u/Greg_DeKoenigsberg1)\
**Post date:** [July 7, 2017, 5:02pm UTC](https://forum.ansible.com/t/jboss-module-enhancements-pr/24901/3 "2017-07-07T17:02:14Z")

</div>

This seems like a good time to ask the question:

Do we want a JBoss Working Group?

Basically, a Working Group is a simple way of putting some structure  
around specific project efforts. Gets you your own IRC channel (if you  
want it) and some project/wiki space in the ansible/community repo.  
It's a good lightweight governance mechanism for working together on  
specific projects.

If you're interested, here's how to start one -- dead simple, by design:

[https://github.com/ansible/community/blob/master/WORKING-GROUPS.md](https://github.com/ansible/community/blob/master/WORKING-GROUPS.md)

--g

---

<div class="post-metadata">

**Author:** ![wrefvem](https://avatars.discourse-cdn.com/v4/letter/w/f6c823/32.png) [@wrefvem](https://forum.ansible.com/u/wrefvem)\
**Post date:** [July 7, 2017, 6:34pm UTC](https://forum.ansible.com/t/jboss-module-enhancements-pr/24901/4 "2017-07-07T18:34:14Z")

</div>

Greg/Jairo–

This sounds like a great idea. Ideas are floating around the community somewhat aimlessly right now, and it would be great if we had a forum to coordinate my work with the great work that Jairo and others are doing. It would also be great to have a place to send Ansible/JBoss users for info/questions/gripes/etc.

Here’s a wrinkle we might want to think about: the community project formerly known as JBoss is now Wildfly, and JBoss is sort of a Red Hat sub-brand assigned to various supported (i.e. paid) middleware/app dev products. To my knowledge, no upstream community project carries the JBoss brand. To avoid confusion, we might want to think about calling the WG something like the Wildfly working group, even if we plan to support pre-Widlfly versoins of JBoss AS (i.e. 7.x and earlier), which I think we should. But I’m not married to that idea. I’d love to hear anyone else’s thoughts.

If we can agree on a name, and Jairo, if you’re interested & available, I’ll go ahead and create a request to form the working group with you and I as members, and we can start coordinating work. I’ll also search out JBoss-related issues and PR’s for other potential members.

---

<div class="post-metadata">

**Author:** ![Antonio\_Insuasti\_Rec](https://avatars.discourse-cdn.com/v4/letter/a/49beb7/32.png) [@Antonio\_Insuasti\_Rec](https://forum.ansible.com/u/Antonio_Insuasti_Rec)\
**Post date:** [July 7, 2017, 10:18pm UTC](https://forum.ansible.com/t/jboss-module-enhancements-pr/24901/5 "2017-07-07T22:18:28Z")

</div>

Hi all

Let me know if you need some help, I’m working on my own module, but i like the idea to work together

---

<div class="post-metadata">

**Author:** ![Jairo\_Junior](https://avatars.discourse-cdn.com/v4/letter/j/8c91f0/32.png) [@Jairo\_Junior](https://forum.ansible.com/u/Jairo_Junior)\
**Post date:** [July 7, 2017, 11:51pm UTC](https://forum.ansible.com/t/jboss-module-enhancements-pr/24901/6 "2017-07-07T23:51:07Z")

</div>

Count me in.

I used JBoss name because of existing modules and I believe JBoss brand is more popular than Wildfly. More popular means more users, so more contributors, feedback and etc… (:

One important thing to notice is that Wildfly is known as the upstream project of JBoss EAP, but other projects that use JBoss’ Architecture and even carry JBoss name in their productized version such as Keycloak (Red Hat SSO), Infinispan (JDG), Teiid (JDV) and apiman can also be managed through Management API or JBoss-CLI. You just can’t deploy applications to them.

So, they’re not Wildfly (Infinispan, Teiid, apiman) but “are JBoss”, and in special cases they’re neither (Keycloak).

---

<div class="post-metadata">

**Author:** ![wrefvem](https://avatars.discourse-cdn.com/v4/letter/w/f6c823/32.png) [@wrefvem](https://forum.ansible.com/u/wrefvem)\
**Post date:** [July 9, 2017, 3:23am UTC](https://forum.ansible.com/t/jboss-module-enhancements-pr/24901/7 "2017-07-09T03:23:07Z")

</div>

That’s a really good point. Let’s call the working gorup JBoss, and we can figure out module naming later.

---

<div class="post-metadata">

**Author:** ![wrefvem](https://avatars.discourse-cdn.com/v4/letter/w/f6c823/32.png) [@wrefvem](https://forum.ansible.com/u/wrefvem)\
**Post date:** [July 10, 2017, 3:01pm UTC](https://forum.ansible.com/t/jboss-module-enhancements-pr/24901/8 "2017-07-10T15:01:06Z")

</div>

All–

I’ve created a [creation request for the JBoss WG](https://github.com/ansible/community/issues/188). Once we have the IRC channel, we should do an initial planning meeting via IRC, so let’s start thinking about when would be a good time for that. For starters, we should figure out which time zone everyone is in. I’m US/Eastern (UTC-4:00).

---

<div class="post-metadata">

**Author:** ![Antonio\_Insuasti\_Rec](https://avatars.discourse-cdn.com/v4/letter/a/49beb7/32.png) [@Antonio\_Insuasti\_Rec](https://forum.ansible.com/u/Antonio_Insuasti_Rec)\
**Post date:** [July 11, 2017, 12:44am UTC](https://forum.ansible.com/t/jboss-module-enhancements-pr/24901/9 "2017-07-11T00:44:40Z")

</div>

Hi all

I’m ECT (UTC-5:00)

---

<div class="post-metadata">

**Author:** ![Greg\_DeKoenigsberg1](https://avatars.discourse-cdn.com/v4/letter/g/838e76/32.png) [@Greg\_DeKoenigsberg1](https://forum.ansible.com/u/Greg_DeKoenigsberg1)\
**Post date:** [July 11, 2017, 3:38pm UTC](https://forum.ansible.com/t/jboss-module-enhancements-pr/24901/10 "2017-07-11T15:38:51Z")

</div>

I’ll be processing this one today.

---

<div class="post-metadata">

**Author:** ![wrefvem](https://avatars.discourse-cdn.com/v4/letter/w/f6c823/32.png) [@wrefvem](https://forum.ansible.com/u/wrefvem)\
**Post date:** [July 11, 2017, 7:25pm UTC](https://forum.ansible.com/t/jboss-module-enhancements-pr/24901/11 "2017-07-11T19:25:02Z")

</div>

Thanks Greg.

---

<div class="post-metadata">

**Author:** ![wrefvem](https://avatars.discourse-cdn.com/v4/letter/w/f6c823/32.png) [@wrefvem](https://forum.ansible.com/u/wrefvem)\
**Post date:** [July 12, 2017, 7:48pm UTC](https://forum.ansible.com/t/jboss-module-enhancements-pr/24901/12 "2017-07-12T19:48:44Z")

</div>

Greg–

Again, thanks for suggesting and facilitating the creation of this group. Can you provide any guidance on where to go from here, besides what’s already covered in the docs? Specifically, is there a process we can follow to get PR’s reviewed and ultimately merged?

---

<div class="post-metadata">

**Author:** ![Greg\_DeKoenigsberg1](https://avatars.discourse-cdn.com/v4/letter/g/838e76/32.png) [@Greg\_DeKoenigsberg1](https://forum.ansible.com/u/Greg_DeKoenigsberg1)\
**Post date:** [July 12, 2017, 8:26pm UTC](https://forum.ansible.com/t/jboss-module-enhancements-pr/24901/13 "2017-07-12T20:26:19Z")

</div>

> Greg--
> 
> Again, thanks for suggesting and facilitating the creation of this group.  
> Can you provide any guidance on where to go from here, besides what's  
> already covered in the docs? Specifically, is there a process we can follow  
> to get PR's reviewed and ultimately merged?

In general, the process for getting module PRs reviewed and merged is  
ultimately the same -- get the PR Bot to give you the thumbs up on all  
tests, and get the maintainer of the module to agree that the PR is worth  
merging.

The tricky thing can be getting everyone on the same page on those things  
in a timely manner. The async nature of distributed development can be a  
significant hindrance.

IMO, that's where Working Groups are valuable: they provide structure for a  
group of people who are dedicated to solving these problems, in the same  
place at the same time, to shorten the feedback loops.

So I would say:  
\* make sure the owners of the various JBoss modules are in your working  
group;  
\* make sure to set up regular IRC meetings when they can all be present to  
review PRs;  
\* make sure everyone is hanging out in the #ansible-jboss channel so that  
you have quick/easy access to each other.

The Working Groups really aren't that complicated. They're just a very  
simple way of encouraging people to work together, with just a little bit  
of infrastructure/process to help.

Take a look at how the Windows and Testing Working Groups operate. I feel  
like they're setting the standard right now.

--g

---

<div class="post-metadata">

**Author:** ![Jairo\_Junior](https://avatars.discourse-cdn.com/v4/letter/j/8c91f0/32.png) [@Jairo\_Junior](https://forum.ansible.com/u/Jairo_Junior)\
**Post date:** [July 16, 2017, 11:59pm UTC](https://forum.ansible.com/t/jboss-module-enhancements-pr/24901/14 "2017-07-16T23:59:56Z")

</div>

Sorry couldn’t answer sooner. Lot of things going on - including joining Red Hat (:

GMT -0300 here

---

<div class="post-metadata">

**Author:** ![wrefvem](https://avatars.discourse-cdn.com/v4/letter/w/f6c823/32.png) [@wrefvem](https://forum.ansible.com/u/wrefvem)\
**Post date:** [July 17, 2017, 2:29am UTC](https://forum.ansible.com/t/jboss-module-enhancements-pr/24901/15 "2017-07-17T02:29:53Z")

</div>

Great, well welcome!

How does everyone feel about doing our first meeting an hour before the core team meeting on Tuesday? This would be 3pm for Jairo, 2pm for me, 1pm for Antonio.

---

<div class="post-metadata">

**Author:** ![Antonio\_Insuasti\_Rec](https://avatars.discourse-cdn.com/v4/letter/a/49beb7/32.png) [@Antonio\_Insuasti\_Rec](https://forum.ansible.com/u/Antonio_Insuasti_Rec)\
**Post date:** [July 17, 2017, 3:44pm UTC](https://forum.ansible.com/t/jboss-module-enhancements-pr/24901/16 "2017-07-17T15:44:27Z")

</div>

It's ok for me... see you all tomorrow #ansible-jboss

---

<div class="post-metadata">

**Author:** ![Jairo\_Junior](https://avatars.discourse-cdn.com/v4/letter/j/8c91f0/32.png) [@Jairo\_Junior](https://forum.ansible.com/u/Jairo_Junior)\
**Post date:** [July 18, 2017, 2:12am UTC](https://forum.ansible.com/t/jboss-module-enhancements-pr/24901/17 "2017-07-18T02:12:52Z")

</div>

As I said. Crazy schedule with all the moving, travelling, onboarding and etc.

An async conversation would suit me better right now. So, I promise to read and contribute to whatever you guys discuss regarding JBoss.

---

<div class="post-metadata">

**Author:** ![gundalow](https://sea1.discourse-cdn.com/ansible/user_avatar/forum.ansible.com/gundalow/32/99_2.png) [@gundalow](https://forum.ansible.com/u/gundalow)\
**Post date:** [December 3, 2018, 11:17am UTC](https://forum.ansible.com/t/jboss-module-enhancements-pr/24901/18 "2018-12-03T11:17:28Z")

</div>

Hi,  
Looks like there are a few JBoss PRs open that would benefit from a review:

PRs [https://github.com/ansible/ansible/pulls?utf8=%E2%9C%93&q=label%3Ajboss+is%3Apr±label%3Abackport+is%3Aopen+](https://github.com/ansible/ansible/pulls?utf8=%E2%9C%93&q=label%3Ajboss+is%3Apr+-label%3Abackport+is%3Aopen+)  
Everything: [https://github.com/ansible/ansible/labels/jboss](https://github.com/ansible/ansible/labels/jboss)

When reviewing if you can detail what you’ve tested that gives us the confidence to merge the code.

We also have #ansible-jboss on Freendoe

Kind regards,  
John “gundalow” Barker
