# How best to submit new modules requiring AWS permission changes?

**URL:** <https://forum.ansible.com/t/how-best-to-submit-new-modules-requiring-aws-permission-changes/26844>\
**Category:** Ansible Developer\
**Tags:** aws\
**Created:** [February 25, 2018, 2:24am UTC](https://forum.ansible.com/t/how-best-to-submit-new-modules-requiring-aws-permission-changes/26844 "2018-02-25T02:24:04Z")\
**Posts on this page:** 1\
**Page:** 1

<div class="post-metadata">

**Author:** ![Ed\_C](https://avatars.discourse-cdn.com/v4/letter/e/c67d28/32.png) [@Ed\_C](https://forum.ansible.com/u/Ed_C)\
**Post date:** [February 25, 2018, 2:24am UTC](https://forum.ansible.com/t/how-best-to-submit-new-modules-requiring-aws-permission-changes/26844/1 "2018-02-25T02:24:04Z")

</div>

I’m currently finishing off a couple of new modules to control additional AWS services (specifically the Simple Email Service). Because these are interacting with new services they require new permissions to be granted for the integration tests to run.

If I just submit these as pull requests the integration tests fail in the shippable build so the bot marks the PRs as needing\_revision.

What’s the right way to indicate that the PR is actually ready for review and the tests are only failing due to permissions?

I’m adding the necessary permissions to the IAM policies in hacking/aws\_config and checking that the tests do pass with these permissions.

I’m assuming that a PR with a failed build and needs\_revision tag is just going to be ignored. If these are reviewed anyway then I’ll just explain the context in the PR description.

Thanks in advance  
Ed