# FreeBSD sysctl fixes

**URL:** <https://forum.ansible.com/t/freebsd-sysctl-fixes/15826>\
**Category:** Ansible Project\
**Created:** [July 31, 2014, 8:39pm UTC](https://forum.ansible.com/t/freebsd-sysctl-fixes/15826 "2014-07-31T20:39:39Z")\
**Posts on this page:** 3\
**Page:** 1

<div class="post-metadata">

**Author:** ![Berend\_de\_Boer](https://avatars.discourse-cdn.com/v4/letter/b/e495f1/32.png) [@Berend\_de\_Boer](https://forum.ansible.com/u/Berend_de_Boer)\
**Post date:** [July 31, 2014, 8:39pm UTC](https://forum.ansible.com/t/freebsd-sysctl-fixes/15826/1 "2014-07-31T20:39:39Z")

</div>

Hi ansible,

Any more comments on my FreeBSD sysctl fixes? [https://github.com/ansible/ansible/pull/8256](https://github.com/ansible/ansible/pull/8256)

You’re probably very busy, so don’t want to push anyone around here, but in case it had inadvertently dropped off the radar, just a gentle reminder. Would be very nice to have this in the next release, if that works for you guys.

All the best,

Berend.

---

<div class="post-metadata">

**Author:** ![Michael\_DeHaan1](https://avatars.discourse-cdn.com/v4/letter/m/5e9695/32.png) [@Michael\_DeHaan1](https://forum.ansible.com/u/Michael_DeHaan1)\
**Post date:** [July 31, 2014, 9:39pm UTC](https://forum.ansible.com/t/freebsd-sysctl-fixes/15826/2 "2014-07-31T21:39:19Z")

</div>

Discussion on pull requests is a better subject for ansible-devel usually.

All being said, I followed up with a question 3 days ago and it got flagged P3, and there are 160 of those in queue right now.

I had first requested some whitespace commits not go in, and this was fixed by a revert - which doesn’t solve the history problem.

It appears there are now about 12 other commits in there, so the best thing to do would be to resubmit this as a squashed patch containing just the one commit.

Commits that take spaces in and add them back completely miss the point we had originally - which was about not breaking attribution on those lines in source control history, when there was no need to change those lines.

---

<div class="post-metadata">

**Author:** ![Berend\_de\_Boer](https://avatars.discourse-cdn.com/v4/letter/b/e495f1/32.png) [@Berend\_de\_Boer](https://forum.ansible.com/u/Berend_de_Boer)\
**Post date:** [August 2, 2014, 2:38am UTC](https://forum.ansible.com/t/freebsd-sysctl-fixes/15826/3 "2014-08-02T02:38:52Z")

</div>

> It appears there are now about 12 other commits in there, so the best thing to do would be to resubmit this as a squashed patch containing just the one commit.

Have done so: [https://github.com/ansible/ansible/pull/8406](https://github.com/ansible/ansible/pull/8406)

With 160 P3 pull requests, it seems ansible is successful!

Didn’t know about ansible devel, will use that in the future.