# Extend ec2\_facts or new module?

**URL:** <https://forum.ansible.com/t/extend-ec2-facts-or-new-module/16982>\
**Category:** Ansible Developer\
**Tags:** aws\
**Created:** [December 8, 2014, 1:41am UTC](https://forum.ansible.com/t/extend-ec2-facts-or-new-module/16982 "2014-12-08T01:41:55Z")\
**Posts on this page:** 2\
**Page:** 1

<div class="post-metadata">

**Author:** ![Rob\_White](https://avatars.discourse-cdn.com/v4/letter/r/71c47a/32.png) [@Rob\_White](https://forum.ansible.com/u/Rob_White)\
**Post date:** [December 8, 2014, 1:41am UTC](https://forum.ansible.com/t/extend-ec2-facts-or-new-module/16982/1 "2014-12-08T01:41:55Z")

</div>

I am going to write some code to take advantage of the ec2-get-password function ([http://docs.aws.amazon.com/AWSEC2/latest/CommandLineReference/ApiReference-cmd-GetPassword.html](http://docs.aws.amazon.com/AWSEC2/latest/CommandLineReference/ApiReference-cmd-GetPassword.html)). In my eyes, this is an ec2 fact. It is also probably that most of the time, this sensitive password is not wanted.

Should I extend ec2\_facts and add an options flag (e.g. get\_windows\_password) to get the password if this flag is true? The default would be false.

Alternatively should I just write a separate module to get the password?

Personally i think the ec2\_facts option makes sense but i don’t want to submit a pull request if its unlikely to be accepted because i dont want to maintain the merges if ec2\_facts changes in the future.

---

<div class="post-metadata">

**Author:** ![Michael\_DeHaan1](https://avatars.discourse-cdn.com/v4/letter/m/5e9695/32.png) [@Michael\_DeHaan1](https://forum.ansible.com/u/Michael_DeHaan1)\
**Post date:** [December 8, 2014, 5:19pm UTC](https://forum.ansible.com/t/extend-ec2-facts-or-new-module/16982/2 "2014-12-08T17:19:48Z")

</div>

I’d vote for your own module or variation of it, and probably not submitting it back, reason for it below…

We’re going to be doing some things involving fact saving - and fact caching essentially is this, so returning this plaintext and storing it by default seems to be potentially a bad thing.
