# custom Windows facts PR

**URL:** <https://forum.ansible.com/t/custom-windows-facts-pr/19621>\
**Category:** Ansible Developer\
**Tags:** windows\
**Created:** [October 27, 2015, 5:28am UTC](https://forum.ansible.com/t/custom-windows-facts-pr/19621 "2015-10-27T05:28:34Z")\
**Posts on this page:** 3\
**Page:** 1

<div class="post-metadata">

**Author:** ![David\_O\_Brien](https://avatars.discourse-cdn.com/v4/letter/d/c0e974/32.png) [@David\_O\_Brien](https://forum.ansible.com/u/David_O_Brien)\
**Post date:** [October 27, 2015, 5:28am UTC](https://forum.ansible.com/t/custom-windows-facts-pr/19621/1 "2015-10-27T05:28:34Z")

</div>

Hi,

I believe that this PR is pretty helpful to get the way facts work on Linux kind of working the same way on Windows as well.

I guess I need a second +1 to get this merged: [https://github.com/ansible/ansible-modules-core/pull/1876](https://github.com/ansible/ansible-modules-core/pull/1876)

Looking forward to more feedback as well.

Cheers  
David

---

<div class="post-metadata">

**Author:** ![Corwin\_Brown](https://avatars.discourse-cdn.com/v4/letter/c/d6d6ee/32.png) [@Corwin\_Brown](https://forum.ansible.com/u/Corwin_Brown)\
**Post date:** [October 27, 2015, 3:20pm UTC](https://forum.ansible.com/t/custom-windows-facts-pr/19621/2 "2015-10-27T15:20:30Z")

</div>

Awesome!

I left an inline comment, but I’ve had a lot of trouble with the way you’re checking for the existence of a param and Ansible 2.0.

Otherwise I for sure need this functionality – one of my tasks for this week was to add this and support for Facter on Windows.

---

<div class="post-metadata">

**Author:** ![Trond\_Hindenes](https://avatars.discourse-cdn.com/v4/letter/t/96bed5/32.png) [@Trond\_Hindenes](https://forum.ansible.com/u/Trond_Hindenes)\
**Post date:** [October 29, 2015, 11:06am UTC](https://forum.ansible.com/t/custom-windows-facts-pr/19621/3 "2015-10-29T11:06:05Z")

</div>

Great work David,  
The only thing left is to test it on the current v2 branch (where strictmode is now enabled ☹ ) and we should be able to get this merged in.
