# Contributing: which branch to use?

**URL:** <https://forum.ansible.com/t/contributing-which-branch-to-use/19239>\
**Category:** Ansible Developer\
**Created:** [September 11, 2015, 2:50pm UTC](https://forum.ansible.com/t/contributing-which-branch-to-use/19239 "2015-09-11T14:50:57Z")\
**Posts on this page:** 9\
**Page:** 1

<div class="post-metadata">

**Author:** ![alexk4work](https://avatars.discourse-cdn.com/v4/letter/a/a3d4f5/32.png) [@alexk4work](https://forum.ansible.com/u/alexk4work)\
**Post date:** [September 11, 2015, 2:50pm UTC](https://forum.ansible.com/t/contributing-which-branch-to-use/19239/1 "2015-09-11T14:50:57Z")

</div>

Hi all,

If I would like to make a patch for the last v1 version, which branch should I use as a base?I’m hesitating between stable\_v1.9 and v1\_modules …

---

<div class="post-metadata">

**Author:** ![Greg\_DeKoenigsberg1](https://avatars.discourse-cdn.com/v4/letter/g/838e76/32.png) [@Greg\_DeKoenigsberg1](https://forum.ansible.com/u/Greg_DeKoenigsberg1)\
**Post date:** [September 11, 2015, 2:58pm UTC](https://forum.ansible.com/t/contributing-which-branch-to-use/19239/2 "2015-09-11T14:58:28Z")

</div>

What's the patch for?

---

<div class="post-metadata">

**Author:** ![alexk4work](https://avatars.discourse-cdn.com/v4/letter/a/a3d4f5/32.png) [@alexk4work](https://forum.ansible.com/u/alexk4work)\
**Post date:** [September 11, 2015, 2:59pm UTC](https://forum.ansible.com/t/contributing-which-branch-to-use/19239/3 "2015-09-11T14:59:37Z")

</div>

I’d like to implement supporting the parameter ‘labels’ for the docker module.

---

<div class="post-metadata">

**Author:** ![Greg\_DeKoenigsberg1](https://avatars.discourse-cdn.com/v4/letter/g/838e76/32.png) [@Greg\_DeKoenigsberg1](https://forum.ansible.com/u/Greg_DeKoenigsberg1)\
**Post date:** [September 11, 2015, 3:42pm UTC](https://forum.ansible.com/t/contributing-which-branch-to-use/19239/4 "2015-09-11T15:42:36Z")

</div>

I think it's unlikely that we'll backport a feature into 1.9.x unless  
it's a critical bugfix at this point, which this is not.

Here's what I'd advise:

1. Look through the PRs open against the Docker module in  
ansible/ansible-modules-core now. Make sure it's not a duplicate of  
one of those.  
2. If it's not, file it against 2.0 so we can consider getting it into devel.

--g

---

<div class="post-metadata">

**Author:** ![alexk4work](https://avatars.discourse-cdn.com/v4/letter/a/a3d4f5/32.png) [@alexk4work](https://forum.ansible.com/u/alexk4work)\
**Post date:** [September 11, 2015, 3:58pm UTC](https://forum.ansible.com/t/contributing-which-branch-to-use/19239/5 "2015-09-11T15:58:01Z")

</div>

There is a PR for this for the version 2, but my production servers run ansible 1.9 and it’s unlikely that I shift to 2.0 as soon as it’s released to keep my servers stable.

Anyways, what branch should I use to base my changes on for, say, v1.9.3 ?

---

<div class="post-metadata">

**Author:** ![Greg\_DeKoenigsberg1](https://avatars.discourse-cdn.com/v4/letter/g/838e76/32.png) [@Greg\_DeKoenigsberg1](https://forum.ansible.com/u/Greg_DeKoenigsberg1)\
**Post date:** [September 11, 2015, 4:00pm UTC](https://forum.ansible.com/t/contributing-which-branch-to-use/19239/6 "2015-09-11T16:00:28Z")

</div>

For your local changes, using 1.9.3 as your base sounds reasonable.

--g

---

<div class="post-metadata">

**Author:** ![Brian\_Coca](https://avatars.discourse-cdn.com/v4/letter/b/6de8d8/32.png) [@Brian\_Coca](https://forum.ansible.com/u/Brian_Coca)\
**Post date:** [September 11, 2015, 4:11pm UTC](https://forum.ansible.com/t/contributing-which-branch-to-use/19239/7 "2015-09-11T16:11:43Z")

</div>

actually, for any patches you hope to make it into a minor release you  
should always target the stable- branch, in this case stable-1.9

---

<div class="post-metadata">

**Author:** ![alexk4work](https://avatars.discourse-cdn.com/v4/letter/a/a3d4f5/32.png) [@alexk4work](https://forum.ansible.com/u/alexk4work)\
**Post date:** [September 12, 2015, 1:32pm UTC](https://forum.ansible.com/t/contributing-which-branch-to-use/19239/8 "2015-09-12T13:32:51Z")

</div>

Any chance to put it into the coming 1.9.4 ?

---

<div class="post-metadata">

**Author:** ![alexk4work](https://avatars.discourse-cdn.com/v4/letter/a/a3d4f5/32.png) [@alexk4work](https://forum.ansible.com/u/alexk4work)\
**Post date:** [September 22, 2015, 8:27pm UTC](https://forum.ansible.com/t/contributing-which-branch-to-use/19239/9 "2015-09-22T20:27:29Z")

</div>

Ok, guys, I’ve pushed a PR for this on the stable-1.9. Please review.