# Clarification: Pull requests for bug fixes on master welcome

**URL:** <https://forum.ansible.com/t/clarification-pull-requests-for-bug-fixes-on-master-welcome/11444>\
**Category:** Ansible Project\
**Created:** [April 25, 2012, 1:16pm UTC](https://forum.ansible.com/t/clarification-pull-requests-for-bug-fixes-on-master-welcome/11444 "2012-04-25T13:16:46Z")\
**Posts on this page:** 4\
**Page:** 1

<div class="post-metadata">

**Author:** ![Michael\_DeHaan](https://avatars.discourse-cdn.com/v4/letter/m/c4cdca/32.png) [@Michael\_DeHaan](https://forum.ansible.com/u/Michael_DeHaan)\
**Post date:** [April 25, 2012, 1:16pm UTC](https://forum.ansible.com/t/clarification-pull-requests-for-bug-fixes-on-master-welcome/11444/1 "2012-04-25T13:16:46Z")

</div>

I believe we have at least one active bug on master, dealing with the include tasks/handlers causing a traceback. I need folks fixing bugs as well as submitting features, so this is a pretty easy one to knock out.

I need to investigate why this didn’t break the play books tests (“make tests”) and will be working on that in the next few days.

Meanwhile, I can’t take it right now – but if anyone wants to attempt to fix this on master this would be EXTREMELY useful for people new to the project and trying to those features.

In general, if you find a bug and you know it’s not just a devel branch feature, test it on master, and if it’s broke there, fix it. Combination bug/features don’t count, but I’m basically talking about regressions.

Thanks!

–Michael

---

<div class="post-metadata">

**Author:** ![Matthew\_Williams](https://avatars.discourse-cdn.com/v4/letter/m/a3d4f5/32.png) [@Matthew\_Williams](https://forum.ansible.com/u/Matthew_Williams)\
**Post date:** [April 25, 2012, 4:18pm UTC](https://forum.ansible.com/t/clarification-pull-requests-for-bug-fixes-on-master-welcome/11444/2 "2012-04-25T16:18:22Z")

</div>

Is this the template\_from\_file bug we discussed yesterday?

---

<div class="post-metadata">

**Author:** ![Matthew\_Williams](https://avatars.discourse-cdn.com/v4/letter/m/a3d4f5/32.png) [@Matthew\_Williams](https://forum.ansible.com/u/Matthew_Williams)\
**Post date:** [April 25, 2012, 4:18pm UTC](https://forum.ansible.com/t/clarification-pull-requests-for-bug-fixes-on-master-welcome/11444/3 "2012-04-25T16:18:38Z")

</div>

(Or related)

---

<div class="post-metadata">

**Author:** ![Michael\_DeHaan](https://avatars.discourse-cdn.com/v4/letter/m/c4cdca/32.png) [@Michael\_DeHaan](https://forum.ansible.com/u/Michael_DeHaan)\
**Post date:** [April 25, 2012, 4:22pm UTC](https://forum.ansible.com/t/clarification-pull-requests-for-bug-fixes-on-master-welcome/11444/4 "2012-04-25T16:22:18Z")

</div>

Yes, Seth has patched on devel, asking for a pull request for master.

Then we can do a point release probably if people are trying the tar balls, but I think most of the world is git cloning devel or master directly.

Which is great 🙂